-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Support MMEngine-based & MMCV-based #108
Conversation
아직 러프하게 작업 중이시기도 하고 이미 염두해두고 계실 수도 있겠습니다만, 제 생각을 정리할 겸 미리 몇 자 적어봅니다.
예시 1) # at /mm/tasks/mmdet.py
if HAS_MMENGINE: # or MMCV_VERSION > 2.0.0
@TASKS.register_module()
class MMDetection:
# mmengine based implementation ...
else:
@TASKS.register_module()
class MMDetection:
# mmcv based implementation ... 예시 2)
# at /mm/tasks/__init__.py
import ...
try:
import mmengine
from .mmengine import MMDetection
except:
import mmcv
from .mmcv import MMDetection
__all__ = [..., 'MMDetection', ...] |
Co-authored-by: Junhwa Song <[email protected]> Signed-off-by: Hakjin Lee <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #108 +/- ##
=======================================
Coverage ? 62.01%
=======================================
Files ? 58
Lines ? 1951
Branches ? 313
=======================================
Hits ? 1210
Misses ? 633
Partials ? 108
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Modification
Support MMEngine-based Frameworks manually
Support MMCV-based Frameworks
Replace MMCV utils with MMEngine utils