Vectorize uniform inputs #1664
Merged
Vectorize uniform inputs #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
heinezen
force-pushed
the
feature/shader_update_optimize
branch
from
9a8eed4 to
7559958
Compare
heinezen
commented
Jul 30, 2024
Comment on lines
357
to
360
| if (not update_off.used) { | ||
| // Uniform value has not been set | ||
| continue; | ||
| } |
There was a problem hiding this comment.
This worries me currently. If all uniforms are set, this should be fine as use would always be true and branch prediction should not be that bad. But if this is only a partial update, then this could get very slow.
There was a problem hiding this comment.
I've solved this by storing the used IDs in an additional vector. This adds an additional lookup but should avoid pipeline flushes.
It's hard to say what the impact of a mispredicted branch would be, so we could change this back in the future if it turns out to only have a marginal effect.
heinezen
force-pushed
the
feature/shader_update_optimize
branch
from
1cc693c to
93896f2
Compare
heinezen
force-pushed
the
feature/shader_update_optimize
branch
from
93896f2 to
b8a12ff
Compare
TheJJ
approved these changes
Aug 2, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vectorizes parts of the renderer to increase the speed of the uniform setting and updating.
The changes so far resulted in a
40%70% increase in FPS for me in stresstest 0.740880 FPS