Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use block indent for aligning after open brackets #1602

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Use block indent for aligning after open brackets #1602

merged 1 commit into from
Nov 23, 2023

Conversation

heinezen
Copy link
Member

Finnaly let's us auto-format the enclosing bracket on a new line.

Before:

this->display_shader->new_mom(
    "mass",
    1337,
    "hide",
    false);

After:

this->display_shader->new_mom(
    "mass",
    1337,
    "hide",
    false
);

@heinezen heinezen added lang: c++ Done in C++ code code quality Does not alter behavior, but beauty of our code labels Nov 23, 2023
TheJJ
TheJJ approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeey

@TheJJ TheJJ merged commit bfa99b5 into SFTtech:master Nov 23, 2023
1 check failed
heinezen added a commit to heinezen/openage that referenced this pull request Nov 27, 2023
@heinezen
Revert "Merge pull request SFTtech#1602 from heinezen/clang-format-al…
4cf5e9f 
…ign"

This reverts commit bfa99b5, reversing
changes made to 4334fff.
heinezen added a commit to heinezen/openage that referenced this pull request Nov 28, 2023
@heinezen
Revert "Merge pull request SFTtech#1602 from heinezen/clang-format-al…
c0505b6 
…ign"

This reverts commit bfa99b5, reversing
changes made to 4334fff.
TheJJ added a commit that referenced this pull request Nov 30, 2023
@TheJJ
Merge pull request #1605 from heinezen/fix/revert_clang_format
2391847 
Revert "Merge pull request #1602 from heinezen/clang-format-align"
@heinezen heinezen deleted the clang-format-align branch December 25, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
code quality Does not alter behavior, but beauty of our code lang: c++ Done in C++ code
Projects
openage code quality
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heinezen @TheJJ