Added work around getsitepackages Issue #715 #1031
Conversation
| @@ -29,7 +29,7 @@ if(NOT CMAKE_PY_INSTALL_PREFIX) | |||
| if(MSVC) | |||
| set(CMAKE_PY_INSTALL_PREFIX "python") | |||
| else() | |||
| py_exec("import site, os; print(os.path.normpath(site.getsitepackages()[0]))" PREFIX) | |||
| py_exec("import os; print(os.path.dirname(os.__file__) + '/site-packages')" PREFIX) | |||
There was a problem hiding this comment.
This breaks the installation for distribution packaging because there the destination path must be the sitepackages directory. What is the intention of this fix, or rather: Why doesn't it work with a virtualenv currently? To solve this correctly, we'll need a more complete solution.
There was a problem hiding this comment.
I would like to quote samkellet from issue #715.
virtualenv has its own site.py which does not have getsitepackages defined.
I was not able to compile on my machine till I changed it.
This also build (kevin-ci) without errors so I thought it was good.
there is an issue for virtualenv saying site.getsitepackages() is missing.
There was a problem hiding this comment.
Please excuse me, you are right, i did not realize the os.__file__'s effect.
Maybe we can improve it further to not depend on this "os.py is one folder above site packages":
https://stackoverflow.com/a/122340/1348535
so we would have:
from distutils.sysconfig import get_python_lib; print(get_python_lib())There is another answer saying that this is false on Ubuntu, but I think it's the path we need.
TheJJ
added
improvement
|
I have updated my pull request. |
|
Thank you! |
Support for building openage under a virtualenv. Issue #715