Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solveig branch #32

Merged
merged 10 commits into from
Feb 4, 2025
Merged

Solveig branch #32

merged 10 commits into from
Feb 4, 2025

Conversation

sot176
Copy link
Contributor

@sot176 sot176 commented Feb 4, 2025

Moved my metric test function into the test directory. Updated the load files with my classes. Updated the choices in the main file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. I'll just add a quick remark that PR #31 changes the way we initialize our models from taking a in_channels: int to a input_shape: tuple[int, int, int], representing a single image with dimensions [channel, height, width].

I think it makes sense to accept your current model, then you can modify it later in PR #31 like Jan, I and soon Johan have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the reminder. I will change my model initialization and adjust it accordingly before merging

@salomaestro
Copy link
Contributor

Also you should try to format your code again with isort. e.g., isort format .

@sot176
Copy link
Contributor Author

sot176 commented Feb 4, 2025

I didn't know about isort but thanks for the tip I will format it properly.

@sot176
Copy link
Contributor Author

sot176 commented Feb 4, 2025

Now the files are properly formatted and the model is updated.

@salomaestro
Copy link
Contributor

Nice work!

@sot176 sot176 merged commit c455b8a into main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants