Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Johan/devbranch #29

Merged
merged 15 commits into from
Feb 4, 2025
Merged

Johan/devbranch #29

merged 15 commits into from
Feb 4, 2025

Conversation

Johanmkr
Copy link
Contributor

@Johanmkr Johanmkr commented Feb 4, 2025

Implemented model and metric.

@Johanmkr Johanmkr requested a review from salomaestro February 4, 2025 09:35
@salomaestro
Copy link
Contributor

Nice! Looks very good. I just have a quick remark:

Solveig set up a tests directory. If you put your tests somewhere in there, for instance those related to metrics in tests/test_metrics.py they will be run automatically when you push towards the main branch.

salomaestro
salomaestro approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@salomaestro salomaestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIcely done. Approving

@salomaestro salomaestro self-requested a review February 4, 2025 12:11
salomaestro
salomaestro requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@salomaestro salomaestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting is failing. Can you format then push again?

@salomaestro salomaestro self-requested a review February 4, 2025 12:14
salomaestro
salomaestro approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@salomaestro salomaestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Ready to merge

@salomaestro salomaestro merged commit a5a6c01 into main Feb 4, 2025
4 checks passed
@Johanmkr
Copy link
Contributor Author

Johanmkr commented Feb 4, 2025

Nice! Looks very good. I just have a quick remark:

Solveig set up a tests directory. If you put your tests somewhere in there, for instance those related to metrics in tests/test_metrics.py they will be run automatically when you push towards the main branch.

Yes i will move the tests into test, thanks for reminding me @salomaestro.

@salomaestro
Copy link
Contributor

Ah I forgot about that, sorry. I think you can revert the merge if you want to have those changes in this PR, if not, just make a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salomaestro salomaestro salomaestro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johanmkr @salomaestro