Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalize inputs to dataloader #23

Closed
salomaestro opened this issue Jan 31, 2025 · 3 comments
Closed

Formalize inputs to dataloader #23

salomaestro opened this issue Jan 31, 2025 · 3 comments
Labels
question Further information is requested

Comments

@salomaestro
Copy link
Contributor

I'm almost done with the model and dataset, but I see we need to formalize what inputs go to the different functions, load_model/data.

I've already pushed a few to the main branch, but I'll list them here, and we can decide what inputs we would like to the models/datasets:

Dataset

load_data(
    dataset_name: str,
    train: bool,
    data_path: pathlib.Path | str,
    download: bool,
)

Model

model = load_model(
    model_name: str,
    in_channels: int,  # So we can input both grayscale and RGB images
    num_classes: int,
)

Any other suggestions?

@hzavadil98
Copy link
Contributor

At this point each model would be specifically tailored for the images from the connected dataset, why don't we pass the whole image.shape to the load_model so that we can make the models flexible to process all the implemented datasets? 🤔 @salomaestro

@salomaestro
Copy link
Contributor Author

@hzavadil98 Good idea. If you have the time, could you open a pull-request/draft pull-request with your proposal?

@hzavadil98
Copy link
Contributor

I'm on it

Seilmast pushed a commit that referenced this issue Feb 7, 2025
Change of load_model parameters addresses #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants