Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Celery threaded attachments #1338

Merged
merged 30 commits into from
Aug 11, 2014
Merged

Celery threaded attachments #1338

merged 30 commits into from
Aug 11, 2014

Conversation

vr2262
Copy link
Contributor

@vr2262 vr2262 commented Aug 8, 2014

I re-ran the dev.formhub.org test, and it worked perfectly.
Assuming this Travis run (https://travis-ci.org/SEL-Columbia/formhub/builds/32053624) works, it's done!
👏 👏 👏

planner and others added 30 commits August 8, 2014 15:04
Use Celery to save attachments, take 1
5fff270
Might need a TransactionTestCase again (see simple_threaded_attachmen…
63f7fdf 
…ts branch)
@vr2262
Tests involving celery may need the Celery test runner
8aac296
@vr2262
Revert "Tests involving celery may need the Celery test runner"
9980c10 
This reverts commit 93491cf.
@vr2262
Change only the otherwise-failing tests to use TransactionTestCase
766add0
@vr2262
Missed some spots
5f98389
@vr2262
Sanity check for the MRO
8d119a2
@vr2262
I guess having two distinct classes is unavoidable
010b908
@vr2262
Cleaned up redundant class definitions and fixed methods that refer t…
dccc7c7 
…o the class
@vr2262
I guess having two classes is really really unavoidable
d36d070
@vr2262
Good old sleep()
156228a
@vr2262
More sleep()
7255fe2
@vr2262
Why did this fail? Throw sleep() at it
64c3a13
@vr2262
Add debugging information
fd75329
@vr2262
Maybe the function can't be inside a function decorated with transact…
32b656c 
…ion.autocommit()
@vr2262
As per the celery docs, transaction.autocommit() is probably causing …
729318c 
…issues
@vr2262
Removed a decorator that was swallowing errors (temporarily)
951a83e
@vr2262
Commit transactions in a paranoid fashion
fea804e
@vr2262
The decorator was swallowing errors, so I'm removing it temporarily
55efacd
Revert "The decorator was swallowing errors, so I'm removing it tempo…
60fa4f4 
…rarily"

Apparently that brings things back to transaction.commit_on_success???

This reverts commit 473b284.
Revert "Commit transactions in a paranoid fashion"
c9cd750 
This reverts commit 872d77e.
Revert "Removed a decorator that was swallowing errors (temporarily)"
ccee2a8 
This reverts commit 162fdf4.
Revert "As per the celery docs, transaction.autocommit() is probably …
75fb9f0 
…causing issues"

This reverts commit d985e3f.
Maybe those sleep() calls weren't actually helping
77613cc
Only spawn celery for _save_attachments if media exists
dacb81c
@vr2262
Fix typo
ccbbd5b
@vr2262
Add debugging information to _save_attachments
baa28e1
@vr2262
This tearDown() might be the holy grail
414b711
Final branch cleanup
30ef895
@vr2262
MRO bites again
d43d52e
@dpapathanasiou
Copy link
Contributor

Hallelujah

dpapathanasiou added a commit that referenced this pull request Aug 11, 2014
@dpapathanasiou
Merge pull request #1338 from SEL-Columbia/celery_threaded_attachments
46c098e 
Celery threaded attachments
@dpapathanasiou dpapathanasiou merged commit 46c098e into master Aug 11, 2014
@dpapathanasiou dpapathanasiou deleted the celery_threaded_attachments branch August 11, 2014 14:27
humanitariandata pushed a commit to humanitariandata/formhub that referenced this pull request Oct 16, 2014
@dpapathanasiou
Merge pull request SEL-Columbia#1338 from SEL-Columbia/celery_threade…
ca4c8e8 
…d_attachments

Celery threaded attachments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vr2262 @dpapathanasiou