iscsi-scst: Add internal_portal parameter #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnocturno
requested changes
Aug 19, 2024
Add an internal_portal parameter to allow specified portals to bypass CHAP controls for both discovery and target login. If not populated, then the current behavior will be preserved.
bmeagherix
force-pushed
the
add_internal_portal
branch
from
b7e96f0 to
1a8dcd7
Compare
|
Hi Gleb, Thanks for reviewing! Please see updated PR. Thanks, |
lnocturno
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
internal_portalparameter to allow specified portals to bypass CHAP controls for both discovery and target login. If not populated, then the current behavior will be preserved.This is particularly useful for "internal" targets used as part of ALUA configuration (only presented on an internal, private portal). It is envisaged that typical use would only be for those ALUA internal targets, and that
internal_portalwould only be set once (most likely to a single IP address, the private portal IP). The main issue being addressed/avoided is that discovery auth is currently global.