Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qla2x00t-32gbit #208

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Update qla2x00t-32gbit #208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5da2ce0
qla2x00t-32gbit: Fix double free of dsd_list during driver load
lnocturno Dec 27, 2023
902385b
qla2x00t-32gbit: Fix system crash due to bad pointer access
lnocturno Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions qla2x00t-32gbit/qla_os.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,13 +1877,21 @@ static void qla2x00_abort_srb(struct qla_qpair *qp, srb_t *sp, const int res,
}

spin_lock_irqsave(qp->qp_lock_ptr, *flags);
switch (sp->type) {
case SRB_SCSI_CMD:
#if HAVE_SCSI_MQ
if (ret_cmd && blk_mq_request_started(scsi_cmd_to_rq(cmd)))
sp->done(sp, res);
if (ret_cmd && blk_mq_request_started(scsi_cmd_to_rq(cmd)))
sp->done(sp, res);
#else
if (ret_cmd && list_empty(&cmd->request->queuelist))
sp->done(sp, res);
if (ret_cmd && list_empty(&cmd->request->queuelist))
sp->done(sp, res);
#endif
break;
default:
if (ret_cmd)
sp->done(sp, res);
break;
}
} else {
sp->done(sp, res);
}
Expand Down Expand Up @@ -5021,7 +5029,7 @@ qla2x00_mem_free(struct qla_hw_data *ha)
ha->gid_list = NULL;
ha->gid_list_dma = 0;

if (!list_empty(&ha->base_qpair->dsd_list)) {
if (ha->base_qpair && !list_empty(&ha->base_qpair->dsd_list)) {
struct dsd_dma *dsd_ptr, *tdsd_ptr;

/* clean up allocated prev pool */
Expand Down