Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename ListSeparators enum to ListSeparator #9308

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Jun 26, 2024

Currently we have BreadcrumbsSeparator in singular form, but ListSeparators in plural and tried to align them.
Looking at the two options, I think the enum values represent individual separator type and should remain in the singular form.

BREAKING CHANGE: The ListSeparators (plural form) enum has been renamed to ListSeparator (singular form).
If you previously imported the ListSeparators:

import ListSeparators from "@ui5/webcomponents/dist/types/ListSeparators.js";
import type ListSeparators from "@ui5/webcomponents/dist/types/ListSeparators.js";

Now, you must import the ListSeparator enumeration as follows:

import ListSeparator from "@ui5/webcomponents/dist/types/ListSeparator.js";
import type ListSeparator from "@ui5/webcomponents/dist/types/ListSeparator.js";

Related to: #8461

@ilhan007 ilhan007 changed the title refactor: rename ListSeparators enum to ListSeparator refactor: rename ListSeparators enum to ListSeparator Jun 26, 2024
@ilhan007 ilhan007 merged commit 26bb513 into main Jun 27, 2024
9 checks passed
@ilhan007 ilhan007 deleted the refactor-list-separators-enum branch June 27, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants