refactor(ui5-combobox, ui5-multi-combobox): prepare for physical list items #9307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenastoyanovaa
changed the title
MapTo0
approved these changes
Jun 27, 2024
ilhan007
pushed a commit
that referenced
this pull request
Jun 30, 2024
… items (#9307) As the ui5-multi-combobox & ui5-combobox will use physical items, additional adjustments need to be performed in order to have a smooth and backward compatible transition. This change renames the text property of the ui5-cb-item-group & ui5-mcb-item-group to header-text in consistency to the ui5-li-group which the ComboBoxItemGroup and MultiComboBoxItemGroup will extend once transitioning to physical items in the list. After the transition from IComboBoxItem/IMultiComboBoxItem to ListItemGroup for the group items code clean up of the non-null assertion operator can be performed as well. BREAKING CHANGE: The ui5-cb-item-group & ui5-mcb-item-group text property is renamed to header-text. If you previously used the text property: <ui5-cb-item-group text="A"> <ui5-cb-item text="Algeria"></ui5-cb-item> </ui5-cb-item-group> <ui5-mcb-item-group text="A"> <ui5-mcb-item text="Afghanistan"></ui5-mcb-item> </ui5-mcb-item-group> Now you must rename it to header-text: <ui5-cb-item-group header-text="A"> <ui5-cb-item text="Algeria"></ui5-cb-item> </ui5-cb-item-group> <ui5-mcb-item-group header-text="A"> <ui5-mcb-item text="Afghanistan"></ui5-mcb-item> </ui5-mcb-item-group> Related to: #8461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
ui5-multi-combobox&ui5-comboboxwill use physical items, additional adjustments need to be performed in order to have a smooth and backward compatible transition.This change renames the
textproperty of theui5-cb-item-group&ui5-mcb-item-grouptoheader-textin consistency to theui5-li-groupwhich theComboBoxItemGroupandMultiComboBoxItemGroupwill extend once transitioning to physical items in the list.After the transition from
IComboBoxItem/IMultiComboBoxItemtoListItemGroupfor the group items code clean up of the non-null assertion operator can be performed as well.BREAKING CHANGE: The
ui5-cb-item-group&ui5-mcb-item-grouptextproperty is renamed toheader-text.If you previously used the
textproperty:Now you must rename it to
header-text:Related to: #8461