-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui5-li): selected property changed to private #9246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add declare
keyword in front of the places where we only want to change the documentation
FYI @MapTo0 |
Related to #9022 |
We only need to update the documentation for the |
@dobrinyonkov @yanaminkova |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my understanding is that we define the "select" property in the base class only (i.e in ListItemBase) and then declare it as inherited property in the subclasses where it makes sense to use it.. In the remaining places (MenuSeparator) no mentioning (i.e. no declaration/definition) of the "select" property. Seems coherent, so approving...
The
selected
property of theui5-li
has been redefined within the class where it is actively utilized. Despite this change, it remains accessible to all components that rely on it.Related to #8461, #7887