Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-li): replace the usage of image property with image slot #9089

Merged
merged 11 commits into from
Jul 2, 2024

Conversation

yanaminkova
Copy link
Member

@yanaminkova yanaminkova commented May 30, 2024

Removes the image property of the ui5-li and renames the imageContent slot to image.

BREAKING CHANGE: The image property of the ui5-li is removed and the imageContent slot is renamed to image.
If you have previously used the image property:

<ui5-li image="./img/HT-1022.jpg">Standard List Item</ui5-li>

or the imageContent slot:

<ui5-li> Avatar inside imageContent slot
	<ui5-avatar slot="imageContent" shape="Square" initials="ABC" color-scheme="Accent2"></ui5-avatar>
</ui5-li>

Now use image slot instead:

<ui5-li> Avatar inside image slot
	<ui5-avatar slot="image" shape="Square" initials="ABC" color-scheme="Accent2"></ui5-avatar>
</ui5-li>

Related to #8461, #7887, #9200

@yanaminkova
Copy link
Member Author

This pull request is currently on hold pending the merge of changes to the SuggestionItem, which uses the image property of the ui5-list. Once those changes are merged, work on this PR will resume.

@ilhan007
Copy link
Member

Not blocked anymore @yanaminkova @dobrinyonkov
#9092 is merged and now this could be continued

@ilhan007 ilhan007 removed the Blocked label Jun 25, 2024
@yanaminkova yanaminkova requested a review from dobrinyonkov July 1, 2024 10:31
@yanaminkova
Copy link
Member Author

Hello @SAP/ui5-webcomponents-topic-rd, @SAP/ui5-webcomponents-topic-rl,
this PR contains changes to samples owned by your teams. Could you please review it?
Thanks!

@yanaminkova yanaminkova requested a review from dobrinyonkov July 2, 2024 09:09
@yanaminkova yanaminkova dismissed TeodorTaushanov’s stale review July 2, 2024 09:22

The requested changes have been implemented approved.

@yanaminkova yanaminkova dismissed nnaydenow’s stale review July 2, 2024 09:22

The requested changes have been implemented and approved.

@yanaminkova yanaminkova merged commit 391ffaa into main Jul 2, 2024
10 checks passed
@yanaminkova yanaminkova deleted the ui5-list-replace-img-prop branch July 2, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants