-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui5-li): replace the usage of image property with image slot #9089
Conversation
This pull request is currently on hold pending the merge of changes to the SuggestionItem, which uses the image property of the ui5-list. Once those changes are merged, work on this PR will resume. |
Not blocked anymore @yanaminkova @dobrinyonkov |
Hello @SAP/ui5-webcomponents-topic-rd, @SAP/ui5-webcomponents-topic-rl, |
packages/website/docs/_samples/main/Carousel/MultipleItemsPerPage/sample.html
Outdated
Show resolved
Hide resolved
The requested changes have been implemented approved.
The requested changes have been implemented and approved.
Removes the
image
property of theui5-li
and renames theimageContent
slot toimage
.BREAKING CHANGE: The
image
property of theui5-li
is removed and theimageContent
slot is renamed toimage
.If you have previously used the
image
property:or the
imageContent
slot:Now use
image
slot instead:Related to #8461, #7887, #9200