-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui5-option): make options physical elements #8903
Conversation
b70a6f3
to
52d4a87
Compare
52d4a87
to
5195bfa
Compare
packages/main/src/OptionBase.ts
Outdated
template: OptionBaseTemplate, | ||
renderer: litRender, | ||
}) | ||
class OptionBase extends UI5Element implements IOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IOption seems to be redundant since we have OptionBase class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the IOption interface here, but we might still need something for the Select.ts file. There we are using the icon property of the Option which is missing in the OptionBase and as well as some other fields in the SelectPopover.hbs as additionalText, isCustom getter. IOption interface there combines all the stuff the select needs from both the custom option and the option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes, otherwise it looks and works good to me.
90d11a1
to
f65c1e4
Compare
caa16f1
to
4f403fc
Compare
3c3beb0
to
53c35d3
Compare
53c35d3
to
4f49349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add notes for
additionalTextState
,description
,iconEnd
,image
,movable
,accessibleName
,deleteButton
,imageContent
. Also documentaiton ofselected
should be adjusted. Same apply for the OptionCustom class and for some of the parts.
Removes the
ui5-select-menu
andui5-select-menu-option
components.BREAKING CHANGE: The
ui5-select-menu
andui5-select-menu-option
components are removed. Custom options can now be created using theui5-option-custom
, directly placed inside the default slot of theui5-select
SelectMenu & SelectMenuOption
ui5-select-menu
ui5-select-menu-option
ui5-option-custom
If you have previously used the
ui5-select-menu
andui5-select-menu-option
:Now use just
ui5-select
andui5-option-custom
instead:Select
menu
The
menu
property of theui5-select
is removed.Related to #8461, #7887