Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-popup): handle multiple _open calls #8647

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix(ui5-popup): handle multiple _open calls #8647

merged 1 commit into from
Apr 4, 2024

Conversation

dimovpetar
Copy link
Contributor

No description provided.

nnaydenow
nnaydenow reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@nnaydenow nnaydenow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though that we are switching to declarative opening of popup at all and we are removing these showAt / openBy... methods. Do we plan to leave these methods ?

@dimovpetar dimovpetar force-pushed the popup_handle_multiple_open_calls branch from d9701a2 to 60d0b66 Compare April 4, 2024 14:12
@dimovpetar
Copy link
Contributor Author

I though that we are switching to declarative opening of popup at all and we are removing these showAt / openBy... methods. Do we plan to leave these methods ?

I am not aware of these plans. If we do it, then I guess this code can be deleted carefully. Until then we need it to prevent never closing popover in the TabContainer.

@nnaydenow nnaydenow added the 2.0 label Apr 4, 2024
@dimovpetar dimovpetar merged commit 906a8d8 into release-2.0 Apr 4, 2024
9 checks passed
@dimovpetar dimovpetar deleted the popup_handle_multiple_open_calls branch April 4, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow left review comments

@vladitasev vladitasev vladitasev approved these changes

@alexandar-mitsev alexandar-mitsev Awaiting requested review from alexandar-mitsev

@TeodorTaushanov TeodorTaushanov Awaiting requested review from TeodorTaushanov

Assignees
No one assigned
Labels
2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dimovpetar @vladitasev @nnaydenow