Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-dynamic-page): validate aria-controls reference before rendering #11033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NakataCode
Copy link
Contributor

Problem:

  • Invalid ARIA attributes were being generated when the referenced header element wasn't available with the exact ID.

Solution:

  • Now we check if the header element exists before setting the aria-controls attribute, preventing invalid ARIA references.

Fixes: #10987

@NakataCode NakataCode marked this pull request as ready for review March 7, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamicPage: ARIA attributes must conform to valid values - [a11y issue]
1 participant