test(ui5-segmented-button): migrate tests to cypress #11022
Draft
+250
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didip1000
changed the title
hinzzx
requested changes
Mar 6, 2025
nnaydenow
reviewed
Mar 7, 2025
nnaydenow
reviewed
Mar 10, 2025
| .as("segmentedButton"); | ||
|
|
||
| cy.get<SegmentedButton>("@segmentedButton") | ||
| .find("ui5-segmented-button-item") |
There was a problem hiding this comment.
We add pure tag of each components as attribute in order of the scoping feature.
Could you please change all selectors that depend on tag to depend on attribute?
.find("ui5-segmented-button-item") => .find("[ui5-segmented-button-item]")
This will make all tests to work if we decide to test the scoping feature on all test pages.
There was a problem hiding this comment.
Yes, I was supposed to change that earlier but completely forgot, thank you :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.