fix(ui5-table-growing): invalidate table onActivate #10952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborjinik
reviewed
Feb 25, 2025
aborjinik
reviewed
Feb 28, 2025
Comment on lines
+150
to
+152
| if (this.type === TableGrowingMode.Scroll && !this._table) { | ||
| this._invalidateTable(); | ||
| } |
There was a problem hiding this comment.
I am a little confused Duc.
If this._table is not yet set how this._invalidateTable();is going to work? I guess these lines does nothing but then how tests are covering this?
you might probably set this._table in line 151 but can we somehow let the lines 168-170 handle this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With PR #10949, invalidation is fixed. This uncovers an issue in TableGrowing (type: Scroll), where the growing button is not rendered.
This is due to the fact, that during initial rendering the table tries to figure out whether the table exceeds the scrollport, but this is not possible yet, as the feature is not active yet.
Forcing an invalidation of growing activation solves this issue.