Addressing IllegalStateException in OssArtifactSecurityScore #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mibo
requested changes
Jun 4, 2022
| @@ -88,7 +88,9 @@ public ScoreValue calculate(Value<?>... values) { | |||
| } | |||
There was a problem hiding this comment.
I would suggest in case of an unknown score (either artifact or project) to return to combined score as unknown.
Because the OssArtifactSecurityScore take the project score and modify it based on the artifact version score.
If the project score is unknown it can not be modified and just returning the artifact version score is not correct (IMHO).
Other opinions?
As sample (which requires changes additional changes in line 91ff):
Suggested change
| } | |
| } else if (projectSecurityScore.isUnknown()) { | |
| return scoreValue.withMinConfidence().makeUnknown(); | |
| } |
There was a problem hiding this comment.
I agree with your argument. The artifact score should be co-dependent with the ProjectScore. @mibo please check the latest changes. It should reflect what we are discussing here.
…curityScore and OssSecurityScore
sourabhsparkala
force-pushed
the
issue_820
branch
from
db21d36 to
e6bb4bb
Compare
sourabhsparkala
force-pushed
the
issue_820
branch
from
fcb49bd to
e5f68c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #820