fix: Proxy-Authorization token expired issue for cached destination
#5563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ZhongpinWang
changed the title
ZhongpinWang
changed the title
ZhongpinWang
changed the title
ZhongpinWang
changed the title
Proxy-Authorization token expired issue for cached destination
ZhongpinWang
changed the title
Proxy-Authorization token expired issue for cached destinationProxy-Authorization token expired issue for cached destination
deekshas8
reviewed
Feb 26, 2025
ZhongpinWang
deleted the
fix-move-add-proxy-configuration-after-caching
branch
ZhongpinWang
added a commit
that referenced
this pull request
Feb 27, 2025
…#5563) * feat: use existing proxy authorization header if not expired * fix: lint * chore: add changeset * fix: remove expiration check * fix: lint * fix: lint * revert
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not cache destination with
proxyConfigurationany more. The proxy configuration will be added every time after a destination is fetched from or not from cache.Client credential token is cached anyway already so no performance issue when keep calling
serviceToken()to set proxy authorization token.Closes SAP/cloud-sdk-backlog#1255.
Fix #5131
v3-mainnow, which is not for v4 development.mainbranch (for v4), I've updated (V4-Upgrade-Guide.md)[./V4-Upgrade-Guide.md] in case my change has any implications for users updating to SDK v4