chore: switch workflows to use node 20 and 22 by default #5046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marikaner
commented
Oct 11, 2024
marikaner
changed the title
.github/workflows/blackduck.yml
Outdated
| @@ -14,7 +14,7 @@ jobs: | |||
| - run: git fetch --depth=1 | |||
| - uses: actions/setup-node@v4 | |||
| with: | |||
| node-version: 18 | |||
| node-version: 22 | |||
| cache: 'yarn' | |||
| - run: yarn install --frozen-lockfile | |||
There was a problem hiding this comment.
--ignore-engines here as well?
marikaner
commented
Oct 11, 2024
ZhongpinWang
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 22 is the current node version, so all non-matrix workflows should run on this version by default.
Github actions seems to only allow
node16andnode20according to issues and docs that I found. I didn't try 22 though.The tests are now running on all three versions.