chore: Use correct eslint deps #5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.29.1 to 2.30.0. - [Release notes](https://github.com/import-js/eslint-plugin-import/releases) - [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md) - [Commits](import-js/eslint-plugin-import@v2.29.1...v2.30.0) --- updated-dependencies: - dependency-name: eslint-plugin-import dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This reverts commit e4b3e66.
tomfrenken
reviewed
Sep 30, 2024
| 'import/no-useless-path-segments': [ | ||
| 'error', | ||
| { | ||
| noUselessIndex: true |
There was a problem hiding this comment.
I'm surprised this isn't the default
tomfrenken
reviewed
Sep 30, 2024
packages/odata-v4/package.json
Outdated
| @@ -47,7 +47,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@sap-cloud-sdk/test-services-odata-v4": "^3.21.0", | |||
| "nock": "^14.0.0-beta.6", | |||
| "nock": "^14.0.0-beta.14", | |||
There was a problem hiding this comment.
I assume this change is not directly related to the PR?
tomfrenken
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use the eslint import plugin incorrectly without the correct resolver and typescript eslint plugin. According to the documentation this is required: https://github.com/import-js/eslint-plugin-import/tree/main?tab=readme-ov-file#typescript
When adjusting the config many of the rules did report errors. I fixed them all except some that would otherwise fail the circular dependency check (@ZhongpinWang please take a look at this, maybe you remember some hidden issues that were not tested, but I hope we have everything covered by tests).
I also removed the "no-relative-parent-imports" rule because this actually breaks to many things and it has likely never really worked. If we would like to keep that rule we would need to make major changes to the code.
I found this because I thought there was an incorrect report for one specific dependency in the import plugin: import-js/eslint-plugin-import#3069