chore: Move release relevant actions to GH actions #4993
Conversation
…-changelogs # Conflicts: # yarn.lock
| @@ -13,7 +16,7 @@ export const validMessageTypes = [ | |||
| interface Change { | |||
| packageNames: string[]; | |||
| commit: string; | |||
| type: typeof validMessageTypes[number]; | |||
| type: (typeof validMessageTypes)[number]; | |||
There was a problem hiding this comment.
[q] Unrelated to this PR and also not often used I guess, but do you know why 'Updated Dependencies' is already plural?
There was a problem hiding this comment.
I have no idea. But I am already working on a follow up where this won't matter anymore. I think this is not meant to be used manually.
Co-authored-by: Deeksha Sinha <[email protected]>
Co-authored-by: Deeksha Sinha <[email protected]>
| const content = await readFile(fileName, { encoding: 'utf-8' }); | ||
| const match = content.match(parseCs); | ||
| if (!match) { | ||
| console.error( |
There was a problem hiding this comment.
I did not find any replacement for this logic in your code.
I take it you deliberately removed this validation step?
There was a problem hiding this comment.
The validate changeset message types was moved to the check-pr/merge-changelog action, but maybe validate structure (parseCs) should also be moved there?
| const unifiedChangelog = await readFile('CHANGELOG.md', { encoding: 'utf8' }); | ||
| await writeFile( | ||
| 'CHANGELOG.md', | ||
| unifiedChangelog.split('\n').slice(0, 30).join('\n') + |
There was a problem hiding this comment.
Can you explain this a bit?
This looks like the first (arbitrarily?) 30 lines are taken, put in front of the new changelog & version, and then the remaining lines are attached at the end??
There was a problem hiding this comment.
I can't really to be honest. I think this just takes out the comments that we have in the changelog file. Nobody is touching it manually anyways, so they are not helpful. I didn't touch this logic in this PR, only moved it to a different place.
There is quite some logic going on when merging the changesets, so I didn't want to repeat it. Also bumping and tagging the version is the same action, so moved all three of those into actions, so that we can reuse them in our other project.
I had to refactor a few places to not duplicate the code and I changes smaller things along the way (removing
unixEOLand executing file write and read options async instead of sync).I left a few TODOs for potential follow ups (does not have to happen immediately, but I would like to attempt it on the friday ;) ). I would like to separate those from this already big PR.