fix: fix token exchange #4915
Merged
fix: fix token exchange #4915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomfrenken
reviewed
Aug 14, 2024
| @@ -129,8 +129,8 @@ export async function getAllDestinationsFromDestinationService( | |||
| logger.debug( | |||
| 'Attempting to retrieve all destinations from destination service.' | |||
| ); | |||
| if (shouldExchangeToken(options)) { | |||
| options.jwt = await exchangeToken(options); | |||
| if (shouldExchangeToken(options) && options.jwt) { | |||
There was a problem hiding this comment.
I assume you only added this so the IDE doesn't complain?
Because shouldExchangeToken only returns true if options.jwt is set.
There was a problem hiding this comment.
Alternatively, you could use options.jwt! in the exchangeToken function call but I do not really have a [pp] here.
if (shouldExchangeToken(options)) {
options.jwt = await exchangeToken(options.jwt!);
}There was a problem hiding this comment.
exactly. Using ! is worse in my opinion.
tomfrenken
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token exchange was looking at the token's audiences before and basically did a token verification for XSUAA in the case of IAS tokens. This is incorrect, the token should be merely exchanged.