Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support comparison operators for missing edm types #2519

Merged
merged 11 commits into from
Jun 7, 2022

Conversation

ZhongpinWang
Copy link
Contributor

@ZhongpinWang ZhongpinWang commented May 31, 2022

Closes SAP/cloud-sdk-backlog#488.

Edm.String, Edm.Boolean, and Edm.Guid are primitive OData types and should support all six operations. Thus, they are changed from EdmTypeField to OrderableEdmTypeField.

I also added lt, le, gt, ge for the string filter function, which makes, e.g., the following case possible

filterFunctions().substring('abcde', 1).greaterOrEqual('bcde');

@ZhongpinWang ZhongpinWang marked this pull request as ready for review May 31, 2022 13:05
Copy link
Contributor

@FrankEssenberger FrankEssenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I have overseen it but could you add tests that for the primitive types the filter which are supposed to be present are also there.

@ZhongpinWang ZhongpinWang merged commit c3166ff into main Jun 7, 2022
@ZhongpinWang ZhongpinWang deleted the support-comparison-operators-for-missing-edm-types branch June 7, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants