chore: Replace lerna with turborepo + changesets #2321
Conversation
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
# Conflicts: # yarn.lock
This reverts commit 80d23ad.
# Conflicts: # yarn.lock
# Conflicts: # package.json # yarn.lock
florian-richter
changed the title
# Conflicts: # yarn.lock
| `; | ||
| const disableEslint = '/* eslint-disable */'; | ||
|
|
||
| generateCommonEntity(); |
There was a problem hiding this comment.
Minor: Perhaps you can add a technical debt ticket that we rename this to generate-common-service and create also service,api, complextype... files so that this service is more like the other ones - but this is really if we have not something better to do so most likely never.
There was a problem hiding this comment.
I agree that we may want to improve but a ticket feels unnecessary because it will be super low prio. Also it is quite obvious that this is different and a bit lacking so it wont be hard to find this if you somehow find time to work on it. @marikaner would you prefer I add this tech debt item?
| - CLI is amazingly simple: | ||
| - Create a changeset with `yarn changeset`. | ||
| - Apply changeset with `yarn changeset version`. | ||
| - Create release with `yarn changeset publish` or `yarn changeset publish --tag beta`. |
There was a problem hiding this comment.
Serious Question: How we plan to do the intermediate period? Let's say we merge this PR tonight, then there are already unpublished changes on the main branch which are not modeled in the per package changeset. However, our release script relies now on the changeset - will this cause problem?
There was a problem hiding this comment.
Or do we simply do a bit handy work for the next release on the generated changelog file and after this the lib will work fine because there are no untracked changes?
There was a problem hiding this comment.
Good point. I will migrate the changes we have so far into the changesets format. We may need a check before the next release that nothing was added without a changeset, but that should be low effort.
# Conflicts: # packages/eslint-config/package.json
Closes SAP/cloud-sdk-backlog#579.
What is included?
package.jsonfiles (mostly changed npm scripts + moved some scripts from top level to the individual packages)test-servicespackage into more granular dependencies (common test services are now no longer part ofodata-common)turbo.jsonconfiguration fileimport foo = require('foo');withimport foo from 'foo';which is effectively equivalent.What to review?
package.jsonandturbo.json.package.json(see if everything works locally).test-services-*test-packages (in comparison to the previous setup).TODO:
generate:common