Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port] EE Plushie & Xenowears #751

Merged
merged 6 commits into from
Sep 16, 2024
Merged

[Port] EE Plushie & Xenowears #751

merged 6 commits into from
Sep 16, 2024

Conversation

PuroSlavKing
Copy link
Contributor

Описание PR

Медиа

image

Тип PR

  • Feature
  • Fix
  • Tweak
  • Balance
  • Refactor
  • Port
  • Translate
  • Resprite

Изменения

🆑 PuroSlavKing

  • add: Портирован счетчик призов и игрушки с ЕЕ, автомат появляется в случайном месте на станции.
  • add: Портирована одежда для ксеносов с ЕЕ, в театромате продаётся традиционная форма Унатхов, ошейник с колокольчиком и так же возможность создать в меню крафта тканевые обёртки, которые надеваются на руки и ноги
  • tweak: Изменены призы в игровых автоматах, теперь за победу выдаются билеты, которые можно обменять на призы в счетчике призов.

PuroSlavKing and others added 5 commits September 16, 2024 17:10
* Xenowears (#519)

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Add a bit of clothing specie related and some tiny misc changes.

Normally i wanted to add the spooders changes here but with the other
spider specie coming in il hold myself for now.

---

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Add clothings
- [x] Loadouts/Vending machines

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![image](https://github.com/Simple-Station/Einstein-Engines/assets/45297731/47865d65-754d-4b70-9c10-19bc9aa55ac6)

</p>
</details>

---

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Xenowears! new non-human related clothings.

---------

Signed-off-by: FoxxoTrystan <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Co-authored-by: VMSolidus <[email protected]>

* ooopsie

---------

Signed-off-by: FoxxoTrystan <[email protected]>
Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
Co-authored-by: VMSolidus <[email protected]>
* Plushie Update! (#654)

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

By multiple requests i bring my PR from Frontier The [PLUSHIE
UPDATE!](new-frontiers-14/frontier-station-14#886)

This PR add a prize vendor machine where you can trade prize ticket for
a toy/plushie, to get ticket you win those in arcade machines.

This PR will give a chance for everyone to get the toys they need in a
special machine and will make plushies in general more random and fun,
in term of random spawns.

WARNING THIS PR DOES NOT MAP THE PRIZE VENDOR AND WILL MOSTLY NEED TO BE
MAPPED.

---

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Prize Vendor
- [x] Prize Tickets
- [x] New Toys/Plushies
- [x] Prizes

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

<details><summary><h1>Media</h1></summary>
<p>

![image](https://github.com/user-attachments/assets/643e6c65-bba0-4eef-8e8e-d3510922e51e)

</p>
</details>

---

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: A ton of new plushies has arrived
- add: Prize counter are here, get your prizes by winning games and
getting prize tickets! and find prize balls!!

* prize counter to spawner

* Arachne Plushie (#531)

Added everyone's favorite Arachne as an adorable soft toy

---

- [x] Place plushie in spawn location(s)

---

<details><summary><h1>Media</h1></summary>
<p>

![ArchnePlush](https://github.com/Simple-Station/Einstein-Engines/assets/114866135/1ec47181-4827-49f9-8605-9a16764dba89)

</p>
</details>

---

:cl:
- add: Plushie

* ooopsie

---------

Co-authored-by: FoxxoTrystan <[email protected]>
Co-authored-by: CodedCrow <[email protected]>
* [Tweak] EE Prototypes Folder

* [Tweak] EE RU FTL
@PuroSlavKing PuroSlavKing added Feature Я хочу добавить что-то новое. Port Я портирую эти коммиты. Ready2Merge PR готов к внесению в репозиторий. labels Sep 16, 2024
@github-actions github-actions bot added Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation labels Sep 16, 2024
Copy link
Contributor

github-actions bot commented Sep 16, 2024

RSI Diff Bot; head commit a38a9fe merging into 2969282
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_EinsteinEngines/Clothing/Neck/Misc/bellcollar.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_EinsteinEngines/Clothing/Neck/mantles/oldmantle.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_EinsteinEngines/Clothing/Neck/mantles/unathimantle.rsi

State Old New Status
equipped-NECK Added
icon Added

Resources/Textures/_EinsteinEngines/Clothing/OuterClothing/Misc/unathirobe.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added

Resources/Textures/_EinsteinEngines/Clothing/Shoes/Misc/clothWrap.rsi

State Old New Status
equipped-FEET Added
equipped-HAND Added
icon Added

Resources/Textures/_EinsteinEngines/Objects/Fun/catplushie.rsi

State Old New Status
black Added
grey Added
orange Added
siames Added
tabby Added
tuxedo Added
white Added

Resources/Textures/_EinsteinEngines/Objects/Fun/corgiplushie.rsi

State Old New Status
corgi Added
girlycorgi Added
robotcorgi Added

Resources/Textures/_EinsteinEngines/Objects/Fun/foxplushie.rsi

State Old New Status
black Added
blue Added
coffee Added
crimson Added
marble Added
orange Added
pink Added
purple Added
red Added

Resources/Textures/_EinsteinEngines/Objects/Fun/petrock.rsi

State Old New Status
fred Added
rock Added
roxie Added

Resources/Textures/_EinsteinEngines/Objects/Fun/prizeticket.rsi

State Old New Status
prizeball Added
ticket Added
ticket_2 Added
ticket_3 Added
ticket_4 Added

Resources/Textures/_EinsteinEngines/Objects/Fun/toys.rsi

State Old New Status
abductor Added
abductor_agent Added
deer Added
gnome Added
grey Added
ipc Added
loveable Added
plushie_arachne Added
plushie_jester Added
plushie_slips Added
plushie_trystan Added
plushie_vulp Added

Resources/Textures/_EinsteinEngines/Objects/Storage/Happyhonk/rock_carrier.rsi

State Old New Status
box-inhand-left Added
box-inhand-right Added
box-open Added
box Added

Resources/Textures/_EinsteinEngines/Structures/Machines/prizecounter.rsi

State Old New Status
icon Added
panel Added
unlit Added

Edit: diff updated after a38a9fe

Copy link
Owner

@Rxup Rxup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error: /Prototypes/_EinsteinEngines/Entities/Objects/Fun/toys.yml(261,13)  File not found. (/Audio/DeltaV/Voice/Vulpkanin/dog_bark1.ogg)
Error: /Prototypes/_EinsteinEngines/Entities/Objects/Fun/prizeticket.yml(114,13)  No EntityPrototype found with id PlushieMothRandom
Error: /Prototypes/_EinsteinEngines/Entities/Objects/Fun/prizeticket.yml(11[7](https://github.com/Rxup/space-station-14/actions/runs/10885967447/job/30204819780?pr=751#step:9:8),13)  No EntityPrototype found with id PlushieMothMusician
Error: /Prototypes/_EinsteinEngines/Entities/Objects/Fun/prizeticket.yml(120,13)  No EntityPrototype found with id PlushieMothBartender
Error: /Prototypes/_EinsteinEngines/Recipes/Lathes/prizecounter.yml(11,11)  No EntityPrototype found with id PlushieMothRandom
Error: /Prototypes/_EinsteinEngines/Recipes/Lathes/prizecounter.yml(1[9](https://github.com/Rxup/space-station-14/actions/runs/10885967447/job/30204819780?pr=751#step:9:10),11)  No EntityPrototype found with id PlushieMothMusician
Error: /Prototypes/_EinsteinEngines/Recipes/Lathes/prizecounter.yml(27,11)  No EntityPrototype found with id PlushieMothBartender
Error: /Prototypes/_EinsteinEngines/Stacks/prizeticket.yml(7,3)  Field "itemSize" not found in "Content.Shared.Stacks.StackPrototype".

@PuroSlavKing
Copy link
Contributor Author

Error: /Prototypes/_EinsteinEngines/Entities/Objects/Fun/toys.yml(261,13)  File not found. (/Audio/DeltaV/Voice/Vulpkanin/dog_bark1.ogg)
Error: /Prototypes/_EinsteinEngines/Entities/Objects/Fun/prizeticket.yml(114,13)  No EntityPrototype found with id PlushieMothRandom
Error: /Prototypes/_EinsteinEngines/Entities/Objects/Fun/prizeticket.yml(11[7](https://github.com/Rxup/space-station-14/actions/runs/10885967447/job/30204819780?pr=751#step:9:8),13)  No EntityPrototype found with id PlushieMothMusician
Error: /Prototypes/_EinsteinEngines/Entities/Objects/Fun/prizeticket.yml(120,13)  No EntityPrototype found with id PlushieMothBartender
Error: /Prototypes/_EinsteinEngines/Recipes/Lathes/prizecounter.yml(11,11)  No EntityPrototype found with id PlushieMothRandom
Error: /Prototypes/_EinsteinEngines/Recipes/Lathes/prizecounter.yml(1[9](https://github.com/Rxup/space-station-14/actions/runs/10885967447/job/30204819780?pr=751#step:9:10),11)  No EntityPrototype found with id PlushieMothMusician
Error: /Prototypes/_EinsteinEngines/Recipes/Lathes/prizecounter.yml(27,11)  No EntityPrototype found with id PlushieMothBartender
Error: /Prototypes/_EinsteinEngines/Stacks/prizeticket.yml(7,3)  Field "itemSize" not found in "Content.Shared.Stacks.StackPrototype".

Не привычно наличие автоматического линтера 😭

@PuroSlavKing PuroSlavKing requested a review from Rxup September 16, 2024 18:34
@PuroSlavKing PuroSlavKing merged commit ce1d6e3 into master Sep 16, 2024
11 checks passed
@PuroSlavKing PuroSlavKing deleted the EEPorts branch September 16, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. Feature Я хочу добавить что-то новое. Port Я портирую эти коммиты. Ready2Merge PR готов к внесению в репозиторий.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants