Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] dop_foxes_sound #1053

Closed
wants to merge 3 commits into from
Closed

[Fix] dop_foxes_sound #1053

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4cacee
dop_foxes_sound
Gooslik Feb 14, 2025
33175b0
Customization Foxes
Gooslik Feb 14, 2025
59759b2
mda
Gooslik Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions Resources/Prototypes/Corvax/Voice/speech_emotes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
id: Howl
name: chat-emote-name-howl
category: Vocal
available: false
icon: Interface/Actions/scream.png
whitelist:
components:
Expand All @@ -29,7 +28,6 @@
id: Growl
name: chat-emote-name-growl
category: Vocal
available: false
icon: Interface/Actions/scream.png
whitelist:
components:
Expand Down
34 changes: 34 additions & 0 deletions Resources/Prototypes/_Backmen/SoundCollections/foxes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
- type: soundCollection
id: FoxesScream
files:
- /Audio/Backmen/Voice/Foxes/foxscream01.ogg
- /Audio/Backmen/Voice/Foxes/foxscream02.ogg
- /Audio/Backmen/Voice/Foxes/foxscream03.ogg
- /Audio/Backmen/Voice/Foxes/foxscream04.ogg

- type: soundCollection
id: FoxesCry
files:
- /Audio/Backmen/Voice/Foxes/foxcry01.ogg
- /Audio/Backmen/Voice/Foxes/foxcry02.ogg

- type: soundCollection
id: FoxesGrowl
files:
- /Audio/Backmen/Voice/Foxes/foxgrowl01.ogg

- type: soundCollection
id: FoxesPurrs
files:
- /Audio/Backmen/Voice/Foxes/foxpurrs01.ogg
- /Audio/Backmen/Voice/Foxes/foxpurrs02.ogg

- type: soundCollection
id: FoxesLaugh
files:
- /Audio/Backmen/Voice/Foxes/foxlaugh01.ogg

- type: soundCollection
id: FoxesHowl
files:
- /Audio/Backmen/Voice/Foxes/foxhowl01.ogg
Comment on lines +9 to +34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Проверьте наличие звуковых файлов

Убедитесь, что все указанные аудиофайлы присутствуют в соответствующих директориях.

🏁 Script executed:

#!/bin/bash
# Проверка наличия звуковых файлов
for file in $(grep -o '/Audio/Backmen/Voice/Foxes/.*\.ogg' Resources/Prototypes/_Backmen/SoundCollections/foxes.yml); do
  if [ -f "$file" ]; then
    echo "✓ Файл существует: $file"
  else
    echo "✗ Файл отсутствует: $file"
  fi
done

Length of output: 3478

Доработать: отсутствуют указанные звуковые файлы и коллекции с одним файлом нуждаются в улучшении

  • В файле Resources/Prototypes/_Backmen/SoundCollections/foxes.yml обнаружены ссылки на аудиофайлы, которые отсутствуют в репозитории:

    • /Audio/Backmen/Voice/Foxes/foxscream01.ogg
    • /Audio/Backmen/Voice/Foxes/foxscream02.ogg
    • /Audio/Backmen/Voice/Foxes/foxscream03.ogg
    • /Audio/Backmen/Voice/Foxes/foxscream04.ogg
    • /Audio/Backmen/Voice/Foxes/foxcry01.ogg
    • /Audio/Backmen/Voice/Foxes/foxcry02.ogg
    • /Audio/Backmen/Voice/Foxes/foxgrowl01.ogg
    • /Audio/Backmen/Voice/Foxes/foxpurrs01.ogg
    • /Audio/Backmen/Voice/Foxes/foxpurrs02.ogg
    • /Audio/Backmen/Voice/Foxes/foxlaugh01.ogg
    • /Audio/Backmen/Voice/Foxes/foxhowl01.ogg

  • Рекомендуется:

    • Обновить или исправить пути к аудиофайлам, чтобы они соответствовали фактическому расположению файлов.
    • Рассмотреть возможность добавления дополнительных звуков для коллекций, где задан только один аудиофайл (например, для коллекций FoxesGrowl, FoxesLaugh, FoxesHowl), если это соответствует целям проекта.