Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foxes Sound #1052

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Foxes Sound #1052

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a446ce3
foxes_sound
Gooslik Feb 13, 2025
aca4c3b
foxes_sound
Gooslik Feb 13, 2025
a7c9625
foxes_sound
Gooslik Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Resources/Audio/Backmen/Voice/Foxes/foxcry01.ogg
View file
Open in desktop
Binary file not shown.
Binary file added Resources/Audio/Backmen/Voice/Foxes/foxlaugh01.ogg
View file
Open in desktop
Binary file not shown.
Binary file added Resources/Audio/Backmen/Voice/Foxes/foxpurrs01.ogg
View file
Open in desktop
Binary file not shown.
Binary file added Resources/Audio/Backmen/Voice/Foxes/foxpurrs02.ogg
View file
Open in desktop
Binary file not shown.
Binary file added Resources/Audio/Backmen/Voice/Foxes/foxscream01.ogg
View file
Open in desktop
Binary file not shown.
Binary file added Resources/Audio/Backmen/Voice/Foxes/foxscream02.ogg
View file
Open in desktop
Binary file not shown.
Binary file added Resources/Audio/Backmen/Voice/Foxes/foxscream03.ogg
View file
Open in desktop
Binary file not shown.
Binary file added Resources/Audio/Backmen/Voice/Foxes/foxscream04.ogg
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions Resources/Prototypes/_Backmen/Entities/Mobs/Species/foxes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@
types:
Asphyxiation: -2.0
- type: Wagging
- type: Vocal
sounds:
Male: MaleFoxes
Female: FemaleFoxes
Unsexed: MaleFoxes


- type: entity
Expand Down
27 changes: 27 additions & 0 deletions Resources/Prototypes/_Backmen/SoundCollections/foxes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
- type: soundCollection
id: FoxesScream
files:
- /Audio/Backmen/Voice/Foxes/foxscream01.ogg
- /Audio/Backmen/Voice/Foxes/foxscream02.ogg
- /Audio/Backmen/Voice/Foxes/foxscream03.ogg
- /Audio/Backmen/Voice/Foxes/foxscream04.ogg

- type: soundCollection
id: FoxesCry
files:
- /Audio/Backmen/Voice/Foxes/foxscry01.ogg

- type: soundCollection
id: FoxesGrowl
files:
- /Audio/Backmen/Voice/Felinid/cat_growl1.ogg

Copy link
Contributor

@coderabbitai coderabbitai bot Feb 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Заменить звук кошачьего рычания на звук лисы

Использование звука кошачьего рычания (cat_growl1.ogg) для лисы может звучать неестественно. Рекомендуется записать и использовать настоящий звук лисьего рычания.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

уже сделано

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧩 Analysis chain

@Gooslik Thanks for confirming! I can see that you've replaced the cat growl sound with the proper fox growl sound. Great job on making this improvement! 🦊

🏁 Script executed:

#!/bin/bash
# Check the current content of the foxes.yml file
cat "Resources/Prototypes/_Backmen/SoundCollections/foxes.yml"

Length of output: 824

I've already provided an appropriate response acknowledging the fix and celebrating the improvement. No additional response is needed as the script output confirms what we already knew.

If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!

- type: soundCollection
id: FoxesPurrs
files:
- /Audio/Backmen/Voice/Foxes/foxpurrs01.ogg

- type: soundCollection
id: FoxesLaugh
files:
- /Audio/Backmen/Voice/Foxes/foxlaugh01.ogg
73 changes: 73 additions & 0 deletions Resources/Prototypes/_Backmen/Voice/speech_emote_sounds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,76 @@
collection: HarpyChirps
Weh:
collection: Weh

- type: emoteSounds
id: MaleFoxes
params:
variation: 0.125
sounds:
Scream:
collection: FoxesScream
Laugh:
collection: FoxesLaugh
Growl:
collection: FoxesGrowl
Howl:
path: /Audio/Corvax/Effects/howl.ogg
Sneeze:
collection: MaleSneezes
Cough:
collection: MaleCoughs
Yawn:
collection: MaleYawn
Snore:
collection: Snores
Sigh:
collection: MaleSigh
Crying:
collection: FoxesCry
Whistle:
collection: Whistles
Weh:
collection: Weh
Gasp:
collection: MaleGasp
DefaultDeathgasp:
collection: MaleDeathGasp
Purrs:
collection: FoxesPurrs


- type: emoteSounds
id: FemaleFoxes
params:
variation: 0.125
sounds:
Scream:
collection: FoxesScreams
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Исправить несоответствие в названии коллекции

В строке 154 используется коллекция FoxesScreams, но в файле foxes.yml она определена как FoxesScream. Необходимо исправить это несоответствие.

    Scream:
-      collection: FoxesScreams
+      collection: FoxesScream
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Scream:
collection: FoxesScreams
Scream:
collection: FoxesScream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправлено

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gooslik Thanks for fixing the collection name! 🎉

If you found this review helpful, would you consider giving us a shout-out on X?
Thank you for using CodeRabbit!

Laugh:
collection: FoxesLaugh
Growl:
collection: FoxesGrowl
Howl:
path: /Audio/Corvax/Effects/howl.ogg
Sneeze:
collection: FemaleSneezes
Cough:
collection: FemaleCoughs
Yawn:
collection: FemaleYawn
Snore:
collection: Snores
Sigh:
collection: FemaleSigh
Crying:
collection: FoxesCry
Whistle:
collection: Whistles
Weh:
collection: Weh
Gasp:
collection: FemaleGasp
DefaultDeathgasp:
collection: FemaleDeathGasp
Purrs:
collection: FoxesPurrs
Loading