Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] Race of races #1020

Merged
merged 5 commits into from
Feb 6, 2025
+53 −0
Merged

[Balance] Race of races #1020

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
429d704
racing
nomad0260 Jan 28, 2025
bb5e33a
imba
nomad0260 Jan 28, 2025
4d0fb86
coderabbit issue
nomad0260 Jan 28, 2025
c6f0b7b
coderabbit balance
nomad0260 Jan 28, 2025
71153af
rouden pidoras
nomad0260 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Resources/Prototypes/Entities/Mobs/Species/dwarf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@
understands:
- TauCetiBasic
- Dwarven
- type: MovementSpeedModifier #backmen: Race of race
baseSprintSpeed: 4
Comment on lines +17 to +18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Скорость дварфов требует корректировки

Базовая скорость спринта 4 в сочетании с высокой устойчивостью к урону может сделать дварфов слишком эффективными. Рекомендуется уменьшить до 3.5.

  - type: MovementSpeedModifier
-   baseSprintSpeed: 4
+   baseSprintSpeed: 3.5
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- type: MovementSpeedModifier #backmen: Race of race
baseSprintSpeed: 4
- type: MovementSpeedModifier #backmen: Race of race
baseSprintSpeed: 3.5

- type: Damageable
damageModifierSet: DwarfSkin
- type: SlowOnDamage
speedModifierThresholds:
60: 0.9
80: 0.7
- type: Hunger
- type: Thirst
- type: Icon
Expand Down
38 changes: 38 additions & 0 deletions Resources/Prototypes/_Backmen/Damage/modifier_sets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,3 +127,41 @@
Cold: 0.5
Heat: 0.8
Shock: 0.5

- type: damageModifierSet
id: CombineHuman
coefficients:
Blunt: 0.8
Slash: 0.8
Piercing: 0.6
Stun: 0.5
Cold: 0.0
Poison: 0.0
Radiation: 0.0
Asphyxiation: -1.0
Bloodloss: 0.0
Cellular: 0.0

Comment on lines +131 to +144
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Необходимо пересмотреть баланс модификаторов CombineHuman.

Текущая реализация создает потенциально имбалансный набор модификаторов:

  • Отрицательный коэффициент для Asphyxiation (-1.0) означает лечение от урона удушьем
  • Полный иммунитет к нескольким типам урона (Cold, Poison, Radiation, Bloodloss, Cellular)

Предлагаемые изменения:

  coefficients:
    Blunt: 0.8
    Slash: 0.8
    Piercing: 0.6
    Stun: 0.5
-   Cold: 0.0
-   Poison: 0.0
-   Radiation: 0.0
-   Asphyxiation: -1.0
-   Bloodloss: 0.0
-   Cellular: 0.0
+   Cold: 0.3
+   Poison: 0.3
+   Radiation: 0.3
+   Asphyxiation: 0.5
+   Bloodloss: 0.3
+   Cellular: 0.3
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- type: damageModifierSet
id: CombineHuman
coefficients:
Blunt: 0.8
Slash: 0.8
Piercing: 0.6
Stun: 0.5
Cold: 0.0
Poison: 0.0
Radiation: 0.0
Asphyxiation: -1.0
Bloodloss: 0.0
Cellular: 0.0
- type: damageModifierSet
id: CombineHuman
coefficients:
Blunt: 0.8
Slash: 0.8
Piercing: 0.6
Stun: 0.5
Cold: 0.3
Poison: 0.3
Radiation: 0.3
Asphyxiation: 0.5
Bloodloss: 0.3
Cellular: 0.3

- type: damageModifierSet
id: FelinidSkin
coefficients:
Blunt: 1.35
Slash: 1.25
Piercing: 1.25
Heat: 1.2
Cold: 1.5
Cellular: 1.1
Bloodloss: 1.25
Shock: 1.25
Radiation: 1.1

- type: damageModifierSet
id: DwarfSkin
coefficients:
Blunt: 0.8
Slash: 0.8
Piercing: 0.8
Cold: 0.7 # Устойчивость к холоду
Heat: 0.9 # Небольшая устойчивость к огню
Poison: 0.8 # Устойчивость к ядам
Radiation: 1.1 # Небольшая уязвимость к радиации
2 changes: 2 additions & 0 deletions Resources/Prototypes/_Backmen/Entities/Mobs/Player/combine.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
- type: Speech
speechSounds: Combine
soundCooldownTime: 0.1
- type: Damageable
damageModifierSet: CombineHuman
- type: Stamina
critThreshold: 250
- type: MobState
Expand Down
1 change: 1 addition & 0 deletions Resources/Prototypes/_Backmen/Entities/Mobs/Species/felinid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
prototype: Felinid
- type: Damageable
damageContainer: Biological
damageModifierSet: FelinidSkin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Необходимо смягчить уязвимости фелинидов

Текущие множители урона (1.35-1.45) делают фелинидов чрезмерно уязвимыми. Учитывая их способности к скрытности, рекомендуется уменьшить множители до 1.15-1.25.

  - type: Damageable
-   damageModifierSet: FelinidSkin
+   damageModifierSet: FelinidSkinBalanced # Требуется создать новый набор модификаторов

Committable suggestion skipped: line range outside the PR's diff.

- type: MeleeWeapon
hidden: true
soundHit:
Expand Down
Loading