Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Syringe gun! #1018
[Feature] Syringe gun! #1018
Changes from 2 commits
14157fa
34dbf79
e60aec8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Обнаружена проблема с тегом SyringeGunAmmo
Тег
SyringeGunAmmo
добавлен к сущностям, но отсутствует проверка этого тега в системе шприц-пистолета (SyringeGunSystem
). Это может привести к тому, что шприц-пистолет будет принимать неправильные типы боеприпасов.SyringeGunAmmo
вContent.Server/_Goobstation/Weapons/Ranged/SyringeGunSystem.cs
GunSystem
🔗 Analysis chain
Проверьте использование тега SyringeGunAmmo
Тег
SyringeGunAmmo
добавлен к базовым сущностям шприцев. Убедитесь, что система шприц-пистолета корректно фильтрует боеприпасы по этому тегу.Also applies to: 424-424
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 32
Script:
Length of output: 5104
Script:
Length of output: 307
Script:
Length of output: 649
Script:
Length of output: 489
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Исправьте дублирование конфигурации
В сущности
MiniSyringe
дублируются параметрыEmbeddableProjectile
из родительской сущностиBaseSyringe
. Рекомендуется удалить дублирование.