Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rand_core: incorrect check on buffer length when seeding RNGs #764

Merged
merged 5 commits into from
Feb 15, 2021
Merged

rand_core: incorrect check on buffer length when seeding RNGs #764

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62fa43e
Create RUSTSEC-0000-0000
dhardy Feb 14, 2021
febea62
Rename RUSTSEC-0000-0000 to RUSTSEC-0000-0000.md
dhardy Feb 15, 2021
0e918c3
Add TOML deliminators and comment
dhardy Feb 15, 2021
5985282
Correct TOML closing deliminator
dhardy Feb 15, 2021
2117761
Merge functions key entries
dhardy Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions crates/rand_core/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "rand_core"
date = "2021-02-12"
url = "https://github.com/rust-random/rand/pull/1096"
categories = ["crypto-failure"]
keywords = []

# Optional: metadata which narrows the scope of what this advisory affects
[affected.functions]
"rand_core::le::read_u32_into" = ["< 0.6.2, >= 0.6.0"]
"rand_core::le::read_u64_into" = ["< 0.6.2, >= 0.6.0"]

[versions]
patched = [">= 0.6.2"]
unaffected = ["< 0.6.0"]
```

# Incorrect check on buffer length when seeding RNGs

Summary: rand_core::le::read_u32_into and read_u64_into have incorrect checks on the source buffer length, allowing the destination buffer to be under-filled.

Implications: some downstream RNGs, including Hc128Rng (but not the more widely used ChaCha*Rng), allow seeding using the SeedableRng::from_seed trait-function with too short keys.