feat: make Zeroizing transparent for cheap conversions
#761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmccallum
force-pushed
the
asref
branch
2 times, most recently
from
7662ee9 to
bc99296
Compare
tarcieri
reviewed
Apr 20, 2022
Sometimes libraries want to be generic across types like `Vec<u8>` and `Box<[u8]>`. Therefore, they use bounds like `T: AsRef<[u8]>`. The `Zeroizing<Vec<u8>>` type should be transparently equivalent to `Vec<u8>` in this regard. This allows `Zeroizing` to be used with all such bounds. Signed-off-by: Nathaniel McCallum <[email protected]>
|
Thank you! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes libraries want to be generic across types like
Vec<u8>andBox<[u8]>. Therefore, they use bounds likeT: AsRef<[u8]>. TheZeroizing<Vec<u8>>type should be transparently equivalent toVec<u8>in this regard. This allowsZeroizingto be used with allsuch bounds.
Signed-off-by: Nathaniel McCallum [email protected]