Fix and test min versions build #363
Conversation
|
Would 'minimal-versions' maybe also a candidate to be within RustCrypto/actions? |
|
@aewag |
|
@aewag I suggested the same thing here, as it were: RustCrypto/block-ciphers#303 (review) |
|
I couldn't port the minimal versions job to a composite action (see RustCrypto/actions#3), so I think I will leave it for a separate PR when the action will be ready. @aewag |
|
|
||
| [features] | ||
| default = ["std"] | ||
| std = ["digest/std"] | ||
| asm = ["sha2-asm"] | ||
| compress = [] # Expose compress function | ||
| asm = ["sha2-asm"] # WARNING: this feature SHOULD NOT be enabled by library crates |
There was a problem hiding this comment.
Can you clarify why was this warning added?
There was a problem hiding this comment.
Because if a crate somewhere deep in your dependency tree enables it, it could become virtually impossible to disable it. Considering that the assembly crates may fail to build on some targets (e.g. see RustCrypto/asm-hashes#34), it can be quite unpleasant for users downstream.
In future we may migrate to the configuration flags approach which we now use in some cipher crates, e.g. see the relevant aes docs.
There was a problem hiding this comment.
Link to the issue is exactly what I was looking for, thanks!
No description provided.