sm3: add OSCCA SM3 secure hash #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OSCCA SM3 secure hash (OSCCA GM/T 0004-2012 SM3) generic hash transformation. Signed-off-by: Tianjia Zhang <[email protected]>
tarcieri
reviewed
Mar 30, 2021
| @@ -0,0 +1,25 @@ | |||
| [package] | |||
| name = "sm3" | |||
There was a problem hiding this comment.
It looks like there is already a published sm3 crate:
The repo/source code is here:
https://github.com/andelf/rust-sca/tree/master/sm3
Perhaps we could ask the author about upstreaming it.
There was a problem hiding this comment.
Putting these crates on RustCrypto would be a better choice, I will try to contact the original author. Thanks.
There was a problem hiding this comment.
I've invited @newpavlov as an owner of sm3 on crates.io.
Feel free to overwrite it with RustCrypto crates. 😁
Also, I've invited @uudiin to rust-sca repo. You can update any READMEs and links.
|
@newpavlov can you add the |
|
@tarcieri |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OSCCA SM3 secure hash (OSCCA GM/T 0004-2012 SM3) generic
hash transformation.