Add bitwise ops to Integer trait
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following bitwise operations: - `BitAnd` - `BitOr` - `BitXor` - `Shl` - `Shr` Additionally adds impls of the `Bit*` traits on `UInt<LIMBS>` directly, in addition to the existing impls on `Wrapping<UInt<LIMBS>>`. This is safe because there is no difference between the "wrapping" or "checked" versions of these operations: they always succeed and there is no "wrapping" behavior to worry about. This is debatably a breaking change but one that is extremely unlikely to cause any problems in practice, especially since `crypto-bigint` v0.3 was just released. To be on the safe side though, these changes will immediately be published in a v0.3.1 release, and the current v0.3.0 yanked so as to prevent any potential incompatibilities.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following bitwise operations:
BitAndBitOrBitXorShlShrAdditionally adds impls of the
Bit*traits onUInt<LIMBS>directly, in addition to the existing impls onWrapping<UInt<LIMBS>>.This is safe because there is no difference between the "wrapping" or "checked" versions of these operations: they always succeed and there is no "wrapping" behavior to worry about.
This is debatably a breaking change but one that is extremely unlikely to cause any problems in practice, especially since
crypto-bigintv0.3 was just released. To be on the safe side though, these changes will immediately be published in a v0.3.1 release, and the current v0.3.0 yanked so as to prevent any potential incompatibilities.