Zero trait
#35
Merged
Zero trait
#35
+154
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts a `Zero` trait from the `Integer` trait which contains only the associated `ZERO` constant and the `is_zero` method with a default implementation. Changes the mandatory bound for `NonZero` to be the `Zero` trait rather than the much more restrictive `Integer` This makes it possible to impl `Zero` on `Limb` even though it doesn't impl the full set of `Integer` traits, and therefore use `NonZero<Limb>`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts a
Zerotrait from theIntegertrait which contains only the associatedZEROconstant and theis_zeromethod with a default implementation.Changes the mandatory bound for
NonZeroto be theZerotrait rather than the much more restrictiveIntegerThis makes it possible to impl
ZeroonLimbeven though it doesn't impl the full set ofIntegertraits, and therefore useNonZero<Limb>.