Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_mod proptests #24

Merged
merged 1 commit into from
Oct 15, 2021
Merged

add_mod proptests #24

merged 1 commit into from
Oct 15, 2021

Conversation

ashWhiteHat
Copy link
Contributor

@ashWhiteHat ashWhiteHat commented Oct 14, 2021 •
edited
Loading

Hi @tarcieri
I added add_mod test and modulo operation.
I changed the way to generate random_mod accordingly 😆
I would be grateful if you could confirm.
Thank you!

@ashWhiteHat ashWhiteHat changed the title add_mod test add_mod proptests Oct 14, 2021
@ashWhiteHat ashWhiteHat changed the title add_mod proptests add_mod proptests and modulo operation Oct 14, 2021
tarcieri
tarcieri reviewed Oct 14, 2021
View reviewed changes
src/uint/modulo.rs Outdated Show resolved Hide resolved
tarcieri
tarcieri reviewed Oct 14, 2021
View reviewed changes
src/uint/rand.rs Outdated Show resolved Hide resolved
@tarcieri
Copy link
Member

The add_mod proptests themselves look good if you can remove the things unrelated to those

@ashWhiteHat
Copy link
Contributor Author

Hi @tarcieri
Thank you for the review!
I removed unnecessary changing.
I modified uint_mod_p function in proptests accordingly.
I would appreciate it if you could check it 🕶

@ashWhiteHat ashWhiteHat changed the title add_mod proptests and modulo operation add_mod proptests Oct 15, 2021
@tarcieri
Copy link
Member

Looks good, thanks!

@tarcieri tarcieri merged commit a848cbe into RustCrypto:master Oct 15, 2021
@tarcieri tarcieri mentioned this pull request Oct 16, 2021
Merged
@tarcieri tarcieri mentioned this pull request Nov 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashWhiteHat @tarcieri