Expose residue params and modulus in DynResidue
#197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality I would like to have:
DynResidueParams
from aDynResidue
object (to be able to, given one residue, initialize another one with the same params);DynResidueParams
(to be able to implement some modulus-depending algorithms, e.g. square root)Edit: I decided to wait on exposing the Montgomery form for now; I will just retrieve before serializing. Exposing it exposes the specific representation used by the residue, and the API needs some thought, e.g. whether we do a range check when assembling a
DynResidue
from the pre-calculated Montgomery form and params.Changes:
DynResidueParams::modulus()
DynResidue::params()