-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing on powerpc to the github CI #3433
base: master
Are you sure you want to change the base?
Conversation
e6f9209
to
0dd777f
Compare
ChangeLog: * .github/workflows/ccpp.yml: Add powerpc target compile and test. Signed-off-by: Owen Avery <[email protected]>
A file last modified before I was born is failing to compile because it intentionally uses implicit function declarations |
erm, darwin ppc (original report) is a native target without rustc support, and you're adding a cross target, still without rustc support, but it's even worse as we don't support cross compilation yet. Do we really want to add this? |
My own take (as someone who cares very much about GCC and Rust portability in the long-term) is that it's not worth spending time on this yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic the only change i would make is i think it shouldnt be part of ccpp.yml workflow on pull requests but make it its own workflow like the bootstrap one where it runs on a cron and we add the build-badge to the readme
I was thinking this would be good for making sure we don't break big endian back ends, but if rustc doesn't support it, it would be impossible at this point to compile the rust libraries we use. Would probably be good to leave this unmerged for now, although the CI logs on this PR might help us troubleshoot anyways. |
I'm not really sure what you're going to test, as I believe it won't even pass the configure step for gcc. But if you're willing to add cross compilation, an easy way is to use crosstool-ng (we use it in compiler explorer to build the various cross gcc). But it won't solve the fact that we only support native compiler with existing rustc support 🤷 ç |
The big issue we'd have with compiling for a target |
This should help solve #2184