Add utf-8 validation for input source #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamaroning
commented
Jul 4, 2023
Comment on lines
221
to
225
| { | ||
| uint8_t input = next_byte (); | ||
| uint32_t input = next_byte (); | ||
|
|
||
| if ((int8_t) input == EOF) | ||
| if ((int32_t) input == EOF) | ||
| return Codepoint::eof (); |
There was a problem hiding this comment.
Changed input from uint8_t to uint32_t so as to differentiate 0xff and EOF.
tamaroning
commented
Jul 4, 2023
Comment on lines
364
to
368
| { | ||
| if (offs >= buffer.size ()) | ||
| return EOF; | ||
|
|
||
| return buffer.at (offs++); | ||
| return (uint8_t) buffer.at (offs++); | ||
| } |
There was a problem hiding this comment.
Added casting to prevend bytes whose MSB is 1 from being sign-extended.
Without casting , for example, 0xfe becomes 0xfffffffe.
tamaroning
commented
Jul 4, 2023
Comment on lines
+1
to
+2
| // { dg-excess-errors "stream did not contain valid UTF-8" } | ||
| � |
There was a problem hiding this comment.
Contains a 0xff in line 2.
There was a problem hiding this comment.
Not ÿ (U+FF) as we see.
gcc/rust/ChangeLog: * lex/rust-lex.cc (Lexer::input_source_is_valid_utf8): New method of `Lexer`. * lex/rust-lex.h: Likewise. * rust-session-manager.cc (Session::compile_crate): Add error. gcc/testsuite/ChangeLog: * rust/compile/broken_utf8.rs: New test. Signed-off-by: Raiki Tamura <[email protected]>
philberty
requested review from
CohenArthur,
P-E-P and
philberty
and removed request for
CohenArthur and
philberty
|
The only thing i might say is it would be nice to have these constants named in some way but utf8 stuff is so specific i dont think that really helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2287