-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite failures with UBSAN #427
Comments
Pointer misalignment reports in byteorder.h are not an issue because the code only sets CAREFUL_ALIGNMENT to 0 on a limited set of architectures that do the right thing without requiring alignment. If you're forcing alignment checking, be sure to also force CAREFUL_ALIGNMENT to 1 in that file. The other issue is a memcmp() call with a 0 length, which was never noticed because a NULL pointer doesn't get dereferenced with a 0 length. I committed a change to avoid such a call. |
Thanks, that makes sense. Appreciated. |
rsync sets CAREFUL_ALIGNMENT for architectures which do not support unaligned access. Disable UBSAN for functions which may use unaligned accesses when CAREFUL_ALIGNMENT is set. Bug: RsyncProject#427
rsync sets CAREFUL_ALIGNMENT for architectures which do not support unaligned access. Disable UBSAN for functions which may use unaligned accesses when CAREFUL_ALIGNMENT is set. Bug: RsyncProject#427
rsync sets CAREFUL_ALIGNMENT for architectures which do not support unaligned access. Disable UBSAN for functions which may use unaligned accesses when CAREFUL_ALIGNMENT is set. Bug: RsyncProject#427 Signed-off-by: Sam James <[email protected]>
rsync sets CAREFUL_ALIGNMENT for architectures which do not support unaligned access. Disable UBSAN for functions which may use unaligned accesses when CAREFUL_ALIGNMENT is set. Bug: RsyncProject#427 Signed-off-by: Sam James <[email protected]>
rsync sets CAREFUL_ALIGNMENT for architectures which do not support unaligned access. Disable UBSAN for functions which may use unaligned accesses when CAREFUL_ALIGNMENT is set. Bug: RsyncProject#427 Signed-off-by: Sam James <[email protected]>
Noticed the following failures when building rsync with Undefined Behavior Sanitizer (UBSAN,
-fsanitize=undefined
):When running the test suite:
At runtime, I also hit:
This is with GCC 12.2.1_p20221231 and GCC 13.0.0_pre20230101.
Full log: build.log
The text was updated successfully, but these errors were encountered: