Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust the code in rel-10_0 branch to work with CodePolicy. #760

Closed
svenoe opened this issue Jan 28, 2021 · 8 comments
Closed

Adjust the code in rel-10_0 branch to work with CodePolicy. #760

svenoe opened this issue Jan 28, 2021 · 8 comments
Labels
tidying Tidying of the code
Milestone
OTOBO 10.0.11

Comments

@svenoe
Copy link
Contributor

svenoe commented Jan 28, 2021

While introducing and adapting CodePolicy to our likings there will be code changes on OTOBO at the same time. See also https://github.com/RotherOSS/CodePolicy/issues/2
@svenoe svenoe added the tidying Tidying of the code label Jan 28, 2021
@svenoe svenoe added this to the OTOBO 10.0 milestone Jan 28, 2021
@svenoe svenoe changed the title Adjust code to work with CodePolicy. Adjust the code to work with CodePolicy. Jan 28, 2021
svenoe pushed a commit that referenced this issue Jan 28, 2021
Issue #760: Add no critic again which was removed in 17a0930 because …
8bb4d1d 
…of open.
svenoe pushed a commit that referenced this issue Jan 28, 2021
Issue #760: Add license headers.
2204774
svenoe pushed a commit that referenced this issue Jan 28, 2021
Issue #760: PerlCritic.
8c28529
svenoe pushed a commit that referenced this issue Jan 28, 2021
Issue #760: PerlCritic.
a60f1d0
svenoe pushed a commit that referenced this issue Jan 29, 2021
Issue #760: Codepolicy after line length change, plus some manual cod…
d2d6be9 
…e tidy.
bschmalhofer added a commit that referenced this issue Feb 5, 2021
@bschmalhofer
Issue #760: fix some POD
21d7846 
so that the final 1; is not part of the POD
bschmalhofer added a commit that referenced this issue Feb 5, 2021
@bschmalhofer
Merge pull request #775 from RotherOSS/issue-#760-RequireEndWithOne
2d4350a 
Issue #760: fix some POD
bschmalhofer added a commit that referenced this issue Feb 6, 2021
@bschmalhofer
Issue #760: eliminate some Perl::Critic warnings
dc4a33f
bschmalhofer added a commit that referenced this issue Feb 6, 2021
@bschmalhofer
Issue #760: eliminate some Subroutines::RequireArgUnpacking warnings
08228db
bschmalhofer added a commit that referenced this issue Feb 6, 2021
@bschmalhofer
Issue #760: Perl::Critic found a bug.
faa4220 
';' used in the element list of a join
bschmalhofer added a commit that referenced this issue Feb 6, 2021
@bschmalhofer
Issue #760: eliminate some more Perl::Critic warnings
20fc382 
Add some TODO comments for open questions.
@bschmalhofer
Copy link
Contributor

bschmalhofer commented Feb 6, 2021 •
edited
Loading

The Perl::Critic failures are now down to eight files.
Determined with ../CodePolicy/bin/otobo.CodePolicy.pl --plugins +TidyAll::Plugin::OTOBO::Perl::PerlCritic -a 1>critic.out
There are some case I don't understand. The relevant lines have been marked with TODO-comments:

Kernel/System/MigrateFromOTRS/CloneDB/Driver/Base.pm
Kernel/System/MigrateFromOTRS/OTOBOCopyFilesFromOTRS.pm
Kernel/System/MigrateFromOTRS/OTOBOOTRSConnectionCheck.pm
Kernel/System/UnitTest/RegisterDriver.pm
Kernel/System/UnitTest/Selenium.pm
Kernel/System/UnitTest/Selenium.pm
Kernel/System/Web/Exception.pm
scripts/backup.pl

These cases have been fixed by changes in the CodePolicy. The TODO-comments have been removed.

bschmalhofer added a commit that referenced this issue Feb 6, 2021
@bschmalhofer
Merge pull request #776 from RotherOSS/issue-#760-perlcritic
04738b3 
Issue #760 perlcritic
@bschmalhofer
Copy link
Contributor

The policy https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitCommaSeparatedStatements might hint at real errors. Make sure that there are no violations of that policy.

@bschmalhofer bschmalhofer mentioned this issue Feb 14, 2021
Closed
bschmalhofer added a commit that referenced this issue Feb 14, 2021
@bschmalhofer
Issue #760: remove some obsolete TODO comments
67a0610
bschmalhofer added a commit that referenced this issue Feb 14, 2021
@bschmalhofer
Merge pull request #796 from RotherOSS/issue-#760-todo
a6aebb9 
Issue #760: remove some obsolete TODO comments
bschmalhofer added a commit that referenced this issue Feb 15, 2021
@bschmalhofer
Issue #760: fix or filter out some more Perl::Critic violations
d0e5048
bschmalhofer added a commit that referenced this issue Feb 15, 2021
@bschmalhofer
Merge pull request #798 from RotherOSS/issue-#760-fix_violations
4bc8d03 
Issue #760: fix or filter out some more Perl::Critic violations
@bschmalhofer
Copy link
Contributor

Only a single Perl::Critic violation is left now. This violation is covered by https://github.com/RotherOSS/CodePolicy/issues/30.

@bschmalhofer
Copy link
Contributor

There are still some violations from OTOBO::Perl::ObjectDependencies;


[checked] Kernel/System/MigrateFromOTRS/CloneDB/Backend.pm
�[33mTidyAll::Plugin::OTOBO::Perl::ObjectDependencies�[0m
�[31mThe following objects are used in the code, but not declared as dependencies:
    'Kernel::Language',
�[0m

@bschmalhofer bschmalhofer mentioned this issue Feb 20, 2021
Closed
bschmalhofer added a commit that referenced this issue Feb 20, 2021
@bschmalhofer
Issue #760: accept some of the reformatting done by Perl::Tidy
bba8042
bschmalhofer added a commit that referenced this issue Feb 20, 2021
@bschmalhofer
Issue #760: accecpt suggestions from Perl::Tidy
1d7aacc 
Only indention of end of line comments.
bschmalhofer added a commit that referenced this issue Feb 20, 2021
@bschmalhofer
Issue #760: remove two trailing lines after DoneTesting();
e5b43e4
bschmalhofer added a commit that referenced this issue Feb 20, 2021
@bschmalhofer
Issue #760: Remove empty line before DoneTesting()
d34b4af 
When there are two empty lines.
bschmalhofer added a commit that referenced this issue Feb 20, 2021
@bschmalhofer
Issue #760: tidying
527a886
bschmalhofer added a commit that referenced this issue May 8, 2021
@bschmalhofer
Issue #760: do not complain about usage of localtime()
bbc4681
bschmalhofer added a commit that referenced this issue May 8, 2021
@bschmalhofer
Issue #760: tidying
52e5260
bschmalhofer added a commit that referenced this issue May 8, 2021
@bschmalhofer
Issue #760: '=cut' should not start POD
a5c5b8e
bschmalhofer added a commit that referenced this issue May 8, 2021
@bschmalhofer
Merge pull request #995 from RotherOSS/issue-#760-more_tidying
dba8386 
Issue #760 more tidying
bschmalhofer added a commit that referenced this issue May 17, 2021
@bschmalhofer
Issue #760: ignore Perl::Critic warnings fo InputOutput::RequireBrief…
50c825d 
…Open
bschmalhofer added a commit that referenced this issue May 17, 2021
@bschmalhofer
Merge pull request #1010 from RotherOSS/issue-#760-require_brief_open
b9c5713 
Issue #760: ignore Perl::Critic warnings fo InputOutput::RequireBriefOpen
bschmalhofer added a commit that referenced this issue May 23, 2021
@bschmalhofer
Issue #760: accept some suggestions from Perl::Tidy
cb3af0e 
Mostly alignment issues
bschmalhofer added a commit that referenced this issue May 23, 2021
@bschmalhofer
Issue #760: accecpt more suggestion from Perl::Tidy
bce81ed 
Mostly where Perl::Tidy did not commpute length of UTF-8 chars correctly.
But accept them anyways, as the alignment is not that important.
bschmalhofer added a commit that referenced this issue May 23, 2021
@bschmalhofer
Issue #760: accept indention proposed by Perl::Tidy
4a842c6 
It's a bit strange, but it does not matter for commented out code.
bschmalhofer added a commit that referenced this issue May 23, 2021
@bschmalhofer
Issue #760: don't separate statements with a comma
099b125
bschmalhofer added a commit that referenced this issue May 23, 2021
@bschmalhofer
Merge pull request #1015 from RotherOSS/issue-#760-character_encoding…
38682a6 
…_none

Issue #760 character encoding none
@bschmalhofer
Copy link
Contributor

Down to 3 failures:

bes:~/devel/OTOBO/otobo (issue-#760-satisfy_more_policies)$ ../CodePolicy/bin/otobo.CodePolicy.pl -a > policy_14.out

Error: 3 file(s) did not pass validation.
 - Kernel/System/Ticket/Event/NotificationEvent/Transport/Email.pm
 - Kernel/System/Calendar/Event/Transport/Email.pm
 - Kernel/System/MigrateFromOTRS/CloneDB/Backend.pm

The failures for the two Event modules are covered by https://github.com/RotherOSS/CodePolicy/issues/44. One failure still open.

bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: add TODO comments
ddd5e2c 
for RotherOSS/CodePolicy:#44
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: the TidyAll::Plugin::OTRS::Perl modules are gone
23e3e67
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: update the object dependencies
42b8750
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: accept suggestions from Perl::Tidy
7c798e5
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: allow usage of open
3e706e0
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: avoid complaints about spelling in POD
716f623
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: allow usage of require
82fac2a
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: accept suggestions from Perl::Tidy
8adeba9
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Merge pull request #1022 from RotherOSS/issue-#760-satisfy_more_policies
ee37050 
Issue #760 satisfy more policies
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Issue #760: accept violation of ObjectManagerCreation
d54bf03 
The localised $Kernel::OM is used to generate a deviant database object.
This is not intuitive, but is a known workaround.
Also accept some suggestions from Perl::Critic.
bschmalhofer added a commit that referenced this issue May 25, 2021
@bschmalhofer
Merge pull request #1023 from RotherOSS/issue-#760-objectmanagercreation
6c24508 
Issue #760: accept violation of ObjectManagerCreation
@bschmalhofer
Copy link
Contributor

Accepted the violation of TidyAll::Plugin::OTOBO::Perl::ObjectManagerCreation in Kernel/System/MigrateFromOTRS/CloneDB/Backend.pm. This leaves two violations that are covered in an existion issue. Closing this issue when the PR for #1000 is merged and when there are no new violations.

@bschmalhofer bschmalhofer changed the title Adjust the code to work with CodePolicy. Adjust the code in rel-10_0 branch to work with CodePolicy. May 27, 2021
@bschmalhofer
Copy link
Contributor

Checked the Codepolicy for the rel-10_0 and the issue-#1000-zzz_reload branches. Looks good. Closing this issue and open one for the rel-10_1 branch.

@bschmalhofer bschmalhofer mentioned this issue May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 10.0.11
Development

No branches or pull requests
2 participants
@bschmalhofer @svenoe