Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnitTest: emit correct TAP in UnitTest/Blacklist.t #472

Closed
bschmalhofer opened this issue Sep 25, 2020 · 2 comments
Closed

UnitTest: emit correct TAP in UnitTest/Blacklist.t #472

bschmalhofer opened this issue Sep 25, 2020 · 2 comments
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended
Milestone
OTOBO 10.0.4

Comments

@bschmalhofer
Copy link
Contributor

This test script calls the Dev::UnitTest::Run command module. The effect is that the TAP from the script and from the command are combined, which throws TAP::Parser off the track.
Essentially we have:

1..2
ok 1 - UnitTest 'NutsAndBolts.t' not executed because blacklisted
1..1
ok 1 - easy success in NutsAndBolts.t
ok 2 - UnitTest 'NutsAndBolts.t' executed because not blacklisted

The lines 3 and 4 are printed by Dev::UnitTest::Run and shouldn't be there.
@bschmalhofer bschmalhofer added the bug Something isn't working as intended label Sep 25, 2020
@bschmalhofer bschmalhofer added this to the OTOBO 10.1 milestone Sep 25, 2020
@bschmalhofer bschmalhofer mentioned this issue Sep 25, 2020
Closed
@bschmalhofer bschmalhofer changed the title UnitTest: emit correct TAP in _UnitTest/Blacklist.t_ UnitTest: emit correct TAP in UnitTest/Blacklist.t Sep 25, 2020
@bschmalhofer bschmalhofer self-assigned this Sep 28, 2020
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.1, OTOBO 10.0.4 Sep 30, 2020
@bschmalhofer
Copy link
Contributor Author

Let's fix this for 10.0.4 as the test suite now uses TAP::Harness there too.
The reason why this happens is not obvious, so let's create a workaround. Call skip_allwhen a env var is set.

@bschmalhofer
Copy link
Contributor Author

Workaround is implemented and looks good. Closing the issue.

bschmalhofer added a commit that referenced this issue Sep 30, 2020
@bschmalhofer
Issue #472: update version of elesticsearch base image
7db1c23
bschmalhofer added a commit that referenced this issue Sep 30, 2020
@bschmalhofer
Merge pull request #498 from RotherOSS/issue-472-SKIP_NUTSANDBOLTS_TEST
3b22959 
Issue #472: update version of elesticsearch base image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended
Projects
None yet
Milestone
OTOBO 10.0.4
Development

No branches or pull requests
1 participant
@bschmalhofer