Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shebang line of the perl scripts #40

Closed
bschmalhofer opened this issue May 23, 2020 · 2 comments
Closed

Shebang line of the perl scripts #40

bschmalhofer opened this issue May 23, 2020 · 2 comments
Milestone
OTOBO 10.0.1

Comments

@bschmalhofer
Copy link
Contributor

The scripts assume that the system Perl in in /usr/bin/perl. However the official Perl docker image has perl in /usr/local/bin. Or some users might want to use perlbrew.

I suggest to change the Shebang to `#!/usr/bin/env perl'
@bschmalhofer
Copy link
Contributor Author

The consensus is to make that change.
In some cases, e.g. when using perlbrew, users might have to adapt the Cronjob that watches the OTOBO Daemon. But that problem exists also for the hardcoded /usr/bin/perl in the Shebang.

bschmalhofer added a commit to bschmalhofer/otobo that referenced this issue May 27, 2020
@bschmalhofer
Issue RotherOSS#40: change the Shebang line to #!/usr/bin/env perl
216c1a0
bschmalhofer added a commit to bschmalhofer/otobo that referenced this issue May 27, 2020
@bschmalhofer
Issue RotherOSS#40: change the shebang to /usr/bin/env perl
df5b9f2 
Removed the -X flag as there is no apparent reason why
all warnings should be turned off.
bschmalhofer added a commit to bschmalhofer/otobo that referenced this issue May 27, 2020
@bschmalhofer
Issue RotherOSS#40: apply the -S trick for /usr/bin/env
9aebca0 
This might not be very portable. A better solution is to get rid of -X altogether.
bschmalhofer added a commit to bschmalhofer/otobo that referenced this issue May 28, 2020
@bschmalhofer
Issue RotherOSS#40: avoid a warning when var/tmp already exists
ea3fe2a
bschmalhofer added a commit to bschmalhofer/otobo that referenced this issue May 28, 2020
@bschmalhofer
Issue RotherOSS#40: remove the workaround of calling 'perl bin/otobo.…
304f458 
…Daemon.pl'

No longer needed as the Shebank line has been adapted
svenoe pushed a commit that referenced this issue May 28, 2020
Merge pull request #50 from bschmalhofer/issue-40-shebang
abfb731 
Issue #40 shebang
bschmalhofer added a commit to bschmalhofer/otobo that referenced this issue May 28, 2020
@bschmalhofer
Issue RotherOSS#40: looks like the -X flag is not needed
f1220ff 
At least it was removed in the HEAD of the ((OTRS)) Comunity Edition
svenoe added a commit that referenced this issue May 28, 2020
@svenoe
Merge pull request #52 from bschmalhofer/issue-40-shebang
22c636a 
Issue #40: looks like the -X flag is not needed
@bschmalhofer
Copy link
Contributor Author

The changes have been made and no complaints so far.

@bschmalhofer bschmalhofer added this to the OTOBO 10.0 milestone Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OTOBO 10.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer