Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remnant support for Perl 5.7 or lower #2913

Closed
bschmalhofer opened this issue Feb 2, 2024 · 1 comment
Closed

Remove remnant support for Perl 5.7 or lower #2913

bschmalhofer opened this issue Feb 2, 2024 · 1 comment
Assignees
@bschmalhofer
Labels
tidying Tidying of the code
Milestone
OTOBO 11.0.1

Comments

@bschmalhofer
Copy link
Contributor

OTOBO currently requires Perl 5.24. So there is no need to accomodate for older versions of Perl. Actually, I found only one such instance in the code, in Kernel/System/HTMLUtils.pm .
@bschmalhofer bschmalhofer added the tidying Tidying of the code label Feb 2, 2024
@bschmalhofer bschmalhofer added this to the OTOBO 11.0 milestone Feb 2, 2024
@bschmalhofer bschmalhofer self-assigned this Feb 2, 2024
bschmalhofer added a commit that referenced this issue Feb 2, 2024
@bschmalhofer
Issue #2913: single quotes in format specifiers of sprintf
7d7bc24 
in the cases where Perl version $^V is the other argument.

Using double quotes is in no way incorrect, just not needed because
no interpolation takes place for these strings.
bschmalhofer added a commit that referenced this issue Feb 2, 2024
@bschmalhofer
Issue #2913: remove check for Perl 5.7.
8d1fd15 
We know that the Perl Version is greater than 5.7, as Perl 5.24 is required.
bschmalhofer added a commit that referenced this issue Feb 2, 2024
@bschmalhofer
Issue #2913: single quotes in format specifiers of sprintf
e4566f4 
in the cases where Perl version $^V is the other argument.

Using double quotes is in no way incorrect, just not needed because
no interpolation takes place for these strings.
bschmalhofer added a commit that referenced this issue Feb 2, 2024
@bschmalhofer
Issue #2913: remove check for Perl 5.7.
5e7a6f0 
We know that the Perl Version is greater than 5.7, as Perl 5.24 is required.
@bschmalhofer
Copy link
Contributor Author

Done, closing this issue.

@bschmalhofer bschmalhofer modified the milestones: OTOBO 11.0, OTOBO 11.0.1 Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
tidying Tidying of the code
Projects
None yet
Milestone
OTOBO 11.0.1
Development

No branches or pull requests
1 participant
@bschmalhofer