Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist DBD::mysql 5.003 #2817

Closed
bschmalhofer opened this issue Jan 12, 2024 · 2 comments
Closed

Blacklist DBD::mysql 5.003 #2817

bschmalhofer opened this issue Jan 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working as intended otobo.CheckModules Related to otobo.CheckModules.pl
Milestone

Comments

@bschmalhofer
Copy link
Contributor

          I just encountered a failure of the Docker build as DBD:;mysql 5.003 could not be built. This leads to the conclusion that not only DBD::mysql 5.001 should be blacklisted, but all versions  > 5.001.

Originally posted by @bschmalhofer in #2548 (comment)

@bschmalhofer bschmalhofer self-assigned this Jan 12, 2024
@bschmalhofer bschmalhofer added this to the OTOBO 10.0.20 milestone Jan 12, 2024
@bschmalhofer bschmalhofer added bug Something isn't working as intended otobo.CheckModules Related to otobo.CheckModules.pl labels Jan 12, 2024
@bschmalhofer bschmalhofer changed the title Blacklist DBD::mysql mit version greater or equal to 5.001 Blacklist DBD::mysql 5.003 Jan 12, 2024
@bschmalhofer
Copy link
Contributor Author

There is a reason why versions > 5.001 were not already blacklisted. bin/otobo.CheckModules.pl only supports blacklisting specific versions. So for now just add 5.003 to the blacklist.

bschmalhofer added a commit that referenced this issue Jan 12, 2024
There are no functional changes. The aim is just to make
the code more similar, so that maintainance is easier.
bschmalhofer added a commit that referenced this issue Jan 12, 2024
Whethe a module is installed depends on the feature, when
the feature of the module has been declared.
bschmalhofer added a commit that referenced this issue Jan 12, 2024
Just to have a nominal minimum version. DBD::mysql 4.00 was released in 2006.
bschmalhofer added a commit that referenced this issue Jan 12, 2024
5.001 was already blacklisted.
This fixes the current problem that the Docker image can't be built.
bschmalhofer added a commit that referenced this issue Jan 12, 2024
@bschmalhofer
Copy link
Contributor Author

DBD::mysql 5.003 is now blacklisted. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended otobo.CheckModules Related to otobo.CheckModules.pl
Projects
None yet
Development

No branches or pull requests

1 participant