Fix dynamic field set value rendering

[stefanhaerter]

There are a few known bugs when rendering a dynamic field set with stored values.

Also, using a dynamic field which is based on BasedEntity in a set causes problems.

[stefanhaerter]

Closed with 4030748 and fea5c67

[bschmalhofer]

Reopening because there is a test failure in scripts/test/DynamicField/ValueSetGet.t which might be related to this issue. Specifically 4030748 .The case in question is the SetOfAgentsAndTexts, test number 85, test case. My hunch is that the test script needs to be updated.

[stefanhaerter]

I'll have a look on monday - thank you for testing =)

[stefanhaerter]

I just encountered the test failure myself and this certainly has something to do with changed behavior of one of the field drivers:

bin/otobo.Console.pl Dev::UnitTest::Run --test ValueSetGet
[13:52:20] /opt/otobo/scripts/test/DynamicField/ValueSetGet.t .. # RandomID is test7946602794100002
[13:52:20] /opt/otobo/scripts/test/DynamicField/ValueSetGet.t .. 36/? 
# Failed test 'SetOfAgentsAndTexts'
# at /opt/otobo/scripts/test/DynamicField/ValueSetGet.t line 1223.
# Caught exception in subtest: Can't use string ("3") as an ARRAY ref while "strict refs" in use at /opt/otobo/Kernel/System/DynamicField/Driver/BaseEntity.pm line 129.
# Seeded srand with seed '20240122' from local date.
[13:52:20] /opt/otobo/scripts/test/DynamicField/ValueSetGet.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/101 subtests

At line 129 in Kernel/System/DynamicField/Driver/BaseEntity.pm is a special behavior for single-value entity fields in sets, which I had to include. Most likely, this needs to be adapted again.

[stefanhaerter]

I was wrong - unit test needed indeed to be adapted.

[stefanhaerter]

@bschmalhofer PR with fix is merged - can you run the tests again to verify that the fix is correct?

[bschmalhofer]

The failure in ValueSetGet.t is gone now. Closing this issue again.