Console command Dev::Package::DocumentationGenerate handles PackageRequired statements erroneously

[stefanhaerter]

I came across a (presumably) typo in

otobo/Kernel/System/Console/Command/Dev/Package/DocumentationGenerate.pm

Lines 195 to 202 in 152bb89

	my $PackageRequired;
	if ( $Param{Structure}{PackageRequired} ) {
	for my $Package ( $Param{Structure}{PackageRequired}->@* ) {
	$PackageRequired .= "$_{Content} $_{Version}\n";
	}
	chomp $PackageRequired;
	}

Firstly, I got a warning in my log:

Use of uninitialized value in concatenation (.) or string at /opt/otobo/Kernel/System/Console/Command/Dev/Package/DocumentationGenerate.pm line 198.

According to debug prints, $_ is undefined, and even if it would be defined, I would expect it to be a reference to a hash, not a hash itself. The loop variable $Package is a hash reference and contains the wanted data.

Personally, I would prefer to include the fix in rel-10_1 because the DocumentationGenerate command was firstly added to this version, but I would also understand if the decision would be to only fix it in rel-11_0.

[bschmalhofer]

I aggree that this should be included in rel-10_1.
The PR is merged.

[stefanhaerter]

Thank you =)

Closed with merged #2428